Add VS Code Insiders and VSCodium to Open In editor picker#1392
Add VS Code Insiders and VSCodium to Open In editor picker#1392juliusmarminge merged 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7cbfe80 to
3796c2f
Compare
3796c2f to
78661af
Compare
Reverts all 10 commits pulled from upstream (add5f34 through 1ae20fa) including our local classifySqliteError fix. Upstream introduced a classifySqliteError import that does not exist in effect@4.0.0-beta.42. Reverting until upstream resolves the version mismatch. Reverted commits: - 1ae20fa fix(persistence): revert classifySqliteError to SqlError({ cause, message }) - 23b3f0c Refactor Codex adapter lifecycle helpers (pingdotgg#1478) - e08cea3 Improve drain semantics via STM in DrainableWorker (pingdotgg#1474) - 83eb396 fix(threads): Keep active-turn runtime errors from ending sessions (pingdotgg#1261) - 59a383e Add Effect.fn refactor checklist (pingdotgg#1476) - fb72607 fix(claude): avoid resetting the Claude model on every turn (pingdotgg#1466) - d8a485e Support gh pr checkout pull request references (pingdotgg#1457) - 02989fe fix(web): improve chat header badge and title flex distribution (pingdotgg#1309) - 648f067 Add VS Code Insiders and VSCodium to Open In editor picker (pingdotgg#1392) - add5f34 Add Claude context window selection support (pingdotgg#1422)
Includes: server settings refactor (pingdotgg#1421), Claude text generation (pingdotgg#1323), security bootstrap fd (pingdotgg#1398), context window selection (pingdotgg#1422), editor picker updates (pingdotgg#1392). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This needs https://github.com/nassimna/t3code/blob/main/apps/web/src/components/Icons.tsx#L23 updated to include VisualStudioCodeInsiders based on https://github.com/vscode-icons/vscode-icons/blob/dd2bedbdd7f952974598a81271a10e2c4723a87a/icons/file_type_vscode-insiders.svg |
Adds

VS Code InsidersandVSCodiumto the existing Open In editor flow.What changed:
vscode-insidersandvscodiumsupportsGotometadata so--gotoworks for both editorsWhy:
PATHValidation:
bun run test src/open.test.tsinapps/serverbun run test:browser src/components/ChatView.browser.tsxinapps/webbun fmtbun lintbun typecheckNote
Low Risk
Low risk: scoped to editor picker/launch wiring and editor availability detection, with added test coverage; main risk is incorrect CLI mapping or
--gotobehavior for the new editors.Overview
Adds VS Code Insiders (
code-insiders) and VSCodium (codium) as supported targets in the “Open in editor” flow, surfacing them in the web picker only when detected as installed.Extends the shared
EDITORScontract with per-editorsupportsGotometadata and updates server launch resolution to use it so line/column paths use--gotofor all supporting editors. Updates/expands server + browser tests to cover availability detection, picker filtering, selection/fallback behavior, and open dispatch for the new editors.Written by Cursor Bugbot for commit 78661af. This will update automatically on new commits. Configure here.
Note
Add VS Code Insiders and VSCodium to the Open In editor picker
vscode-insidersandvscodiumeditor definitions topackages/contracts/src/editor.ts, each withsupportsGoto=true, and exposes them in the picker inapps/web/src/components/chat/OpenInPicker.tsx.shouldUseGotoFlaginapps/server/src/open.tsto accept a full editor definition object and use thesupportsGotoflag, replacing the previous hardcoded check forcursorandvscode.supportsGotoboolean to all existing editor definitions (zed,antigravity, andfile-managerset tofalse).--gotois now driven bysupportsGotoon the editor definition rather than a hardcoded id list, so any future editor withsupportsGoto=truewill automatically get line/column support.Macroscope summarized 78661af.