Close gzipOutputStream after the usage#542
Conversation
Pull Request Test Coverage Report for Build 1107
💛 - Coveralls |
|
Created PR #543 for failing test in master for java11 |
|
@munendrasn Please test it with your application(s) and if you don't see a downside I am ready to merge it. |
|
I did some minor testing, things look good. I haven't done good perf tests were memory could build-up |
|
@munendrasn Again, if you think that this PR is ready for merge please merge it. I don't know if we can add a unit test for it. Try it in your application(s) and if the result is OK please merge it. |
|
@decebals , looks good to me! I ratify what you said. 💭 ps: I was thinking (just thinking) what a unit test would be like to detect memory leak. From what I understand and to be more precise, I would have to start a new jvm just with this test. 💭 |
|
@mhagnumdw Thanks for feedback!
In this case, @munendrasn please press the "Squash and merge" button. It's time for your first PR merge in Pippo 😄.
I think that it's too complicated so let's do it without a test. |
|
@decebals Thanks for the merge access
Regarding this, Github allows Repo admin(in this case you) to set branch rules from Settings, through which only squash-merge can be allowed, all other options remain disabled |
Fixes #541