fix failing test in java11#543
Merged
decebals merged 1 commit intopippo-java:masterfrom May 26, 2020
Merged
Conversation
Pull Request Test Coverage Report for Build 1105
💛 - Coveralls |
Member
|
It's OK for me. |
Collaborator
Author
Member
Member
|
Thanks for fix! |
Member
|
Oh, sorry! Thanks @munendrasn!! I was going to take a look at it today, I ended up accepting the MR without seeing it. I only ran local tests with Java 8. |
Collaborator
Author
|
@mhagnumdw Np :) Previously, PR used to show the status of Travis builds. So, it was easy to know if build succeed or not. I'm not sure what has changed but now, only coveralls status is shown |
Member
|
@decebals, do you know anything about it? |
Member
|
I didn't know about this problem. I merged it because the modification looks trivial and I think that the risk to broke something is very low. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix based on this