Skip to content

fix failing test in java11#543

Merged
decebals merged 1 commit intopippo-java:masterfrom
munendrasn:fix-test
May 26, 2020
Merged

fix failing test in java11#543
decebals merged 1 commit intopippo-java:masterfrom
munendrasn:fix-test

Conversation

@munendrasn
Copy link
Copy Markdown
Collaborator

  • ClassUtilsTest fails in java11. This fixes the issue

Fix based on this

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1105

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.908%

Totals Coverage Status
Change from base Build 1103: 0.0%
Covered Lines: 1408
Relevant Lines: 6427

💛 - Coveralls

@decebals
Copy link
Copy Markdown
Member

It's OK for me.

@munendrasn
Copy link
Copy Markdown
Collaborator Author

@decebals could you please merge this so that I can rebase and rerun PR #542?

@decebals decebals merged commit 7158d40 into pippo-java:master May 26, 2020
@decebals
Copy link
Copy Markdown
Member

@decebals could you please merge this so that I can rebase and rerun PR #542?

Done

@decebals
Copy link
Copy Markdown
Member

Thanks for fix!

@munendrasn munendrasn deleted the fix-test branch May 26, 2020 07:25
@mhagnumdw
Copy link
Copy Markdown
Member

Oh, sorry! Thanks @munendrasn!!

I was going to take a look at it today, I ended up accepting the MR without seeing it. I only ran local tests with Java 8.

@munendrasn
Copy link
Copy Markdown
Collaborator Author

@mhagnumdw Np :)

Previously, PR used to show the status of Travis builds. So, it was easy to know if build succeed or not. I'm not sure what has changed but now, only coveralls status is shown
If we fix that then, it would become easier to know about build status. Otherwise, we have to directly go to Travis page and check

@mhagnumdw
Copy link
Copy Markdown
Member

@decebals, do you know anything about it?

@decebals
Copy link
Copy Markdown
Member

I didn't know about this problem. I merged it because the modification looks trivial and I think that the risk to broke something is very low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants