Upgrade to Go 1.24#2132
Merged
Merged
Conversation
ddelnano
commented
Feb 24, 2025
| name: "internal___poll__errNetClosing_sym_addr3" | ||
| type: UINT64 | ||
| constant: "4989824" | ||
| constant: "4989856" |
Member
Author
There was a problem hiding this comment.
These constant changes are because changing the default go sdk caused our go 1.21 go_cross_binary targets to use a newer minor version:
(ddelnano/upgrade-go-to-1.24) $ go version bazel-bin/src/stirling/obj_tools/testdata/go/test_go_1_21_binary
bazel-bin/src/stirling/obj_tools/testdata/go/test_go_1_21_binary: go1.21.13 X:nocoverageredesign
(main) $ bazel build //src/stirling/obj_tools/testdata/go:test_go_1_21_binary
(main) $ go version bazel-bin/src/stirling/obj_tools/testdata/go/test_go_1_21_binary
bazel-bin/src/stirling/obj_tools/testdata/go/test_go_1_21_binary: go1.21.0 X:nocoverageredesign
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
… 1.21.13) Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/upgrade-go-to-1.24
branch
from
fef9b59 to
088bfe8
Compare
vihangm
approved these changes
Feb 26, 2025
oazizi000
approved these changes
Feb 27, 2025
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Aug 6, 2025
Summary: Upgrade to Go 1.24 Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Existing tests --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 274533b
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: Upgrade to Go 1.24 Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Existing tests --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: Upgrade to Go 1.24 Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Existing tests --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Upgrade to Go 1.24
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Existing tests