Skip to content

Upgrade to Go 1.24 #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelnano merged 4 commits into from
Feb 27, 2025
Merged

Upgrade to Go 1.24 #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fd936b
Update docker images and chef to use Go 1.24
ddelnano Feb 24, 2025
2de2382
Update build to use Go 1.24
ddelnano Feb 24, 2025
7129fb6
Fix offsets since test was compiled with Go 1.21.0 previously (now Go…
ddelnano Feb 24, 2025
088bfe8
#ci:ignore-deps
ddelnano Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pl_go_overrides()

go_download_sdk(
name = "go_sdk",
version = "1.21.0",
version = "1.24.0",
)

go_rules_dependencies()
Expand Down Expand Up @@ -251,8 +251,7 @@ go_download_sdk(
go_download_sdk(
name = "go_sdk_boringcrypto",
experiments = ["boringcrypto"],
# TODO(james): update this to 1.21.0, once there is a 1.21.1 release.
version = "1.20.13",
version = "1.23.5",
)

pip_parse(
Expand Down
2 changes: 1 addition & 1 deletion bazel/pl_build_system.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_test")
load("@rules_python//python:defs.bzl", "py_test")
load("//bazel:toolchain_transitions.bzl", "qemu_interactive_runner")

pl_boringcrypto_go_sdk = ["1.20.13"]
pl_boringcrypto_go_sdk = ["1.23.5"]
pl_supported_go_sdk_versions = ["1.18", "1.19", "1.20", "1.21", "1.22", "1.23"]

# The last version in this list corresponds to the boringcrypto go sdk version.
Expand Down
8 changes: 4 additions & 4 deletions docker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
DOCKER_IMAGE_TAG=202409092344
LINTER_IMAGE_DIGEST=18436897f607dd6b1926c12de13be7e9ed668a17cff133e4da90aad0112a406f
DEV_IMAGE_DIGEST=83eba02bf4ced64161276dee88dcd6f02de5951bb3ce5346a1182c70498156aa
DEV_IMAGE_WITH_EXTRAS_DIGEST=27ff4d9111b77516fdf73715ba6ea23d02de3b790d88f6f70a48c5e1ec53570c
DOCKER_IMAGE_TAG=202502242148
LINTER_IMAGE_DIGEST=eb7613e8aab9eb4620d6fae2618c966092abca8734abf90f0238db7de4535f15
DEV_IMAGE_DIGEST=8316e718b16de940e2a5ac64fb6e57dc9ed28ca2ed437302e339964e9b42c9f2
DEV_IMAGE_WITH_EXTRAS_DIGEST=b6d4c2404b30d06c2322d531620dcbe810a2c534f1cd0aa2389c75ed91d9bc24
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module px.dev/pixie

go 1.21
go 1.24

require (
cloud.google.com/go v0.81.0
Expand Down
6 changes: 3 additions & 3 deletions src/stirling/source_connectors/dynamic_tracer/dynamic_tracing/dwarvifier_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1807,21 +1807,21 @@ probes {
scalar_var {
name: "main__IntStruct_sym_addr1"
type: UINT64
constant: "4989600"
constant: "4989632"
}
}
vars {
scalar_var {
name: "runtime__errorString_sym_addr2"
type: UINT64
constant: "4989792"
constant: "4989824"
}
}
vars {
scalar_var {
name: "internal___poll__errNetClosing_sym_addr3"
type: UINT64
constant: "4989824"
constant: "4989856"
Copy link
Copy Markdown
Member Author

@ddelnano ddelnano Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constant changes are because changing the default go sdk caused our go 1.21 go_cross_binary targets to use a newer minor version:

(ddelnano/upgrade-go-to-1.24) $ go version bazel-bin/src/stirling/obj_tools/testdata/go/test_go_1_21_binary
bazel-bin/src/stirling/obj_tools/testdata/go/test_go_1_21_binary: go1.21.13 X:nocoverageredesign

(main) $ bazel build //src/stirling/obj_tools/testdata/go:test_go_1_21_binary
(main) $ go version bazel-bin/src/stirling/obj_tools/testdata/go/test_go_1_21_binary
bazel-bin/src/stirling/obj_tools/testdata/go/test_go_1_21_binary: go1.21.0 X:nocoverageredesign

}
}
vars {
Expand Down
2 changes: 1 addition & 1 deletion tools/chef/base_image_version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
202409092308
202502242123
4 changes: 2 additions & 2 deletions tools/chef/cookbooks/px_dev/attributes/linux.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
'648b599397548e4bb92429eec6391374c2cbb0edb835e3b3f03d4281c011f401'

default['golang']['download_path'] =
'https://go.dev/dl/go1.21.0.linux-amd64.tar.gz'
'https://go.dev/dl/go1.24.0.linux-amd64.tar.gz'
default['golang']['sha256'] =
'd0398903a16ba2232b389fb31032ddf57cac34efda306a0eebac34f0965a0742'
'dea9ca38a0b852a74e81c26134671af7c0fbe65d81b0dc1c5bfe22cf7d4c8858'

default['golangci-lint']['download_path'] =
'https://github.com/golangci/golangci-lint/releases/download/v1.51.1/golangci-lint-1.51.1-linux-amd64.tar.gz'
Expand Down
4 changes: 2 additions & 2 deletions tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
'8d3709d957c7115610e764621569728be102d213fee15bc1d1aa9d465eb2c258'

default['golang']['download_path'] =
'https://go.dev/dl/go1.21.0.darwin-amd64.tar.gz'
'https://go.dev/dl/go1.24.0.darwin-amd64.tar.gz'
default['golang']['sha256'] =
'b314de9f704ab122c077d2ec8e67e3670affe8865479d1f01991e7ac55d65e70'
'7af054e5088b68c24b3d6e135e5ca8d91bbd5a05cb7f7f0187367b3e6e9e05ee'

default['golangci-lint']['download_path'] =
'https://github.com/golangci/golangci-lint/releases/download/v1.51.1/golangci-lint-1.51.1-darwin-amd64.tar.gz'
Expand Down