-
Notifications
You must be signed in to change notification settings - Fork 28
UtkUnpacker.cpp was modified to load eventWidth from Globals #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Addresses issue #253 |
| GetEventStartTime(), eventCounter); | ||
|
|
||
| //set eventWidth from Globals (loaded from config file) | ||
| eventWidth = Globals::get()->GetEventLengthInTicks(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should use the Unpacker::SetEventWidth() method, eventWidth is protected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this should not be in ProcessRawEvent() as the command will be called repeatedly. I believe it should be placed in UtkUnpacker::InitializeDriver().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this should happen even before that. I think it needs to go in this method. Putting it into UtkUnpacker::InitializeDriver() is too late since it's already started to build events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the first event is already build when UtkUnpacker::InitializeDriver() called? I will try initializing there then.
ksmith0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I can not test it, so I can not approve the pull request.
|
I have tested this. It works as expected and doesn't seem to break anything. It will require new Time Calibrations, but this is to be expected. I tested this on kqxhc. Additionally, this one line change was added to my ornl2016 branch ( https://github.com/tking53/paass/tree/ornl2016 ) as well as Andrew Keeler's e14060 branch ( https://github.com/akeeler/paass/tree/e14060 ) and it works there as well. |
tking53
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected on kqxhc. See my comment for details.
This will make UtkUnpacker to build events with given event width in an input config xml.