Issue 253 #257
Merged
Issue 253 #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This works as expected. I ran this on my laptop with my ornl2016 branch (ubuntu 16.10, kernel 4.8.0-42, gsl 2.3, gcc 6.2-ubuntu). |
tking53
approved these changes
Mar 25, 2017
Collaborator
There was a problem hiding this comment.
as per Stan's suggestion. This works, I added it to my ornl2016 branch and it works (just like the previous fix) and Rin tested it with andrew's e14060 branch. See my above review to my system specifics.
UPDATE: This required me to do a manual rebase on my laptop since github didnt want to. The rebase was painless with just a quick re-push.
Contributor
|
Properly addressed #253. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comment, I modified the merged pull request #254.
UtkUnpacker::InitializeDriver() is called at the first event loop so the fist event was not build with proper time window in #254.
I checked this modification worked fine with the akeeler's e14060 branch.