Skip to content

fix fetching pull request#242

Closed
bjohansebas wants to merge 1 commit intopkgjs:mainfrom
bjohansebas:pull-request
Closed

fix fetching pull request#242
bjohansebas wants to merge 1 commit intopkgjs:mainfrom
bjohansebas:pull-request

Conversation

@bjohansebas
Copy link
Member

For some reason, the API that retrieves issues no longer returns pull requests, so we have to make another API call to get the pull requests. For example, the Express agenda should be like bjohansebas#25, and last time it was like expressjs/discussions#412

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Comment on lines +119 to +120
labels: agendaLabel
})
Copy link
Contributor

@ctcpip ctcpip Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: agendaLabel
})
labels: agendaLabel,
per_page: 100
})

the default page size is 30, which is probably plenty, but we should set it to the max (100). and also on the fetch for issues

@ctcpip
Copy link
Contributor

ctcpip commented Aug 8, 2025

@bjohansebas actually, it seems the original code is getting the PRs successfully. I will push up a new test in a moment to demonstrate

@ctcpip
Copy link
Contributor

ctcpip commented Aug 8, 2025

@bjohansebas #244

@bjohansebas
Copy link
Member Author

Could it be a pagination issue, which is why the pull requests weren’t being fetched? Because the fact that sometimes it doesn’t bring the PRs is a reality, there are PRs I had added to the agenda that never showed up until I realized this was happening.

@ctcpip
Copy link
Contributor

ctcpip commented Aug 8, 2025

confirmed with Sebastian that issues and PRs are being found correctly in #244. it's probably not worth spending time trying to determine why the old code was not finding things. maybe a bug in GH SDK or in how we were using it. in any case, we should be good moving forward

@ctcpip
Copy link
Contributor

ctcpip commented Aug 8, 2025

update: GH API/SDK is flaky. I pulled in Sebastian's changes from there into the other PR #244 so let's use that

@wesleytodd
Copy link
Member

All should be merged via other PRs.

@wesleytodd wesleytodd closed this Aug 8, 2025
@bjohansebas bjohansebas deleted the pull-request branch August 8, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants