Conversation
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
0e8ce47 to
eca1c49
Compare
| labels: agendaLabel | ||
| }) |
There was a problem hiding this comment.
| labels: agendaLabel | |
| }) | |
| labels: agendaLabel, | |
| per_page: 100 | |
| }) |
the default page size is 30, which is probably plenty, but we should set it to the max (100). and also on the fetch for issues
|
@bjohansebas actually, it seems the original code is getting the PRs successfully. I will push up a new test in a moment to demonstrate |
|
Could it be a pagination issue, which is why the pull requests weren’t being fetched? Because the fact that sometimes it doesn’t bring the PRs is a reality, there are PRs I had added to the agenda that never showed up until I realized this was happening. |
|
confirmed with Sebastian that issues and PRs are being found correctly in #244. it's probably not worth spending time trying to determine why the old code was not finding things. maybe a bug in GH SDK or in how we were using it. in any case, we should be good moving forward |
|
update: GH API/SDK is flaky. I pulled in Sebastian's changes from there into the other PR #244 so let's use that |
|
All should be merged via other PRs. |
For some reason, the API that retrieves issues no longer returns pull requests, so we have to make another API call to get the pull requests. For example, the Express agenda should be like bjohansebas#25, and last time it was like expressjs/discussions#412