Skip to content

fix fetching pull request #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjohansebas wants to merge 1 commit into from
Closed

fix fetching pull request #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,31 @@ const pkg = require('./package.json')
state: 'open',
labels: agendaLabel
})

console.log(`Fetching issues for ${r.owner}/${r.repo}: Found ${_agendaIssues.length}`)
for (const i of _agendaIssues) {
console.log(`Adding Issue: ${i.url}`)
if (!agendaIssues.find((ii) => ii.url === i.url)) {
agendaIssues.push(i)
}
}

const _agendaPr = await client.paginate('GET /repos/{owner}/{repo}/pulls', {
owner: r.owner,
repo: r.repo,
state: 'open',
labels: agendaLabel
})
Comment on lines +119 to +120
Copy link
Contributor

@ctcpip ctcpip Aug 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: agendaLabel
})
labels: agendaLabel,
per_page: 100
})

the default page size is 30, which is probably plenty, but we should set it to the max (100). and also on the fetch for issues


for (const pr of _agendaPr) {
if (pr.labels.some(label => label.name === agendaLabel)) {
console.log(`Fetching PRs for ${r.owner}/${r.repo}: Found ${_agendaPr.length}`)
if (!agendaIssues.find((ii) => ii.url === pr.url)) {
console.log(`Adding PR: ${pr.url}`)
agendaIssues.push(pr)
}
}
}
}
console.log(`Found ${agendaIssues.length} total issues for agenda`)

Expand Down
Loading