Fix O(n²) performance issue in FrameRenderer #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a significant performance issue in
FrameRenderer.tswhere the frame color calculation had O(n²) time complexity. The optimization reduces this to O(n) by pre-computing depth totals once instead of filtering all frames for each frame during rendering.Changes
Performance Optimization in
src/renderer/FrameRenderer.ts:Pre-computation of depth totals (before the rendering loop):
totalValueByDepthMap that computes total values at each depth level in a single O(n) passUpdated
#calculateFrameColormethod:totalValueByDepthmap instead of the fullallFramesarrayPerformance Impact
Test Plan
Fixes #30
Fixes #44