Skip to content

Fix O(n²) performance issue in FrameRenderer #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
Dec 2, 2025
Merged

Fix O(n²) performance issue in FrameRenderer #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/renderer/FrameRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,12 @@ export class FrameRenderer {
const borderInsetX = 0.5; // 0.5px border in screen space
const borderInsetY = 0.5; // 0.5px border



// Pre-compute total values at each depth level to avoid O(n²) complexity
const totalValueByDepth = new Map<number, number>()
for (const frame of frames) {
const depth = frame.node.depth
totalValueByDepth.set(depth, (totalValueByDepth.get(depth) ?? 0) + frame.node.value)
}

for (const frame of frames) {
const { node, x1, x2, y1, y2 } = frame
Expand All @@ -86,7 +90,7 @@ export class FrameRenderer {
// Calculate frame color based on relative size within its depth level
const color = this.#calculateFrameColor(
node,
frames,
totalValueByDepth,
primaryColor,
secondaryColor
)
Expand Down Expand Up @@ -177,14 +181,13 @@ export class FrameRenderer {
*/
#calculateFrameColor(
node: FlameNode,
allFrames: Array<{node: FlameNode, x1: number, x2: number, y1: number, y2: number}>,
totalValueByDepth: Map<number, number>,
primaryColor: [number, number, number],
secondaryColor: [number, number, number]
): [number, number, number] {
// Calculate total value at this frame's depth level
const framesAtDepth = allFrames.filter(f => f.node.depth === node.depth)
const totalValueAtDepth = framesAtDepth.reduce((sum, f) => sum + f.node.value, 0)

// Look up the pre-computed total value at this frame's depth level
const totalValueAtDepth = totalValueByDepth.get(node.depth) ?? node.value

// Use the shared color computation function
return getFrameColorBySameDepthRatio(
primaryColor,
Expand Down