Conversation
vayesy
commented
Sep 28, 2022
vayesy
commented
Sep 28, 2022
vayesy
commented
Sep 28, 2022
vayesy
commented
Sep 29, 2022
vovacha
approved these changes
Sep 29, 2022
Contributor
vovacha
left a comment
There was a problem hiding this comment.
Finally, this naming makes sense!
0️⃣ 🚀
2075
reviewed
Sep 30, 2022
Member
2075
left a comment
There was a problem hiding this comment.
would make sense to have the two address spaces reflected here, afair 23 and 24? 23 subzero 24 zero?
Member
Author
|
@2075 we can do that in chain spec file if needed. This might be good idea to differentiate but can also cause some issues (at the beginning) due to address format mismatch. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR & discussion: #90
What's done:
live(clean) version of the chain.uniquespallet to both parachain runtimes.zero- live parachain node, which will be used to run on Polkadot. It does not contain GameDAO/Zero pallets.subzero- dev parachain node, used to run dev/test/stage environments. Contains all pallets.subzero-standalone- dev standalone node. May be used for local development/testing. Contains all pallets.Discussed questions:
rmrkpallet to dev runtime add rmrk2 pallets to parachain #119, once tested also add it to clean (live) runtime