Skip to content

Adds clean parachain runtime#118

Merged
vayesy merged 3 commits intodevfrom
feature/clean-parachain-runtime
Sep 30, 2022
Merged

Adds clean parachain runtime#118
vayesy merged 3 commits intodevfrom
feature/clean-parachain-runtime

Conversation

@vayesy
Copy link
Member

@vayesy vayesy commented Sep 26, 2022

Previous PR & discussion: #90

What's done:

  1. Created separate runtime for live (clean) version of the chain.
  2. Cross-chain transfers enabled.
  3. Added uniques pallet to both parachain runtimes.
  4. Updated local-relay setup with actual runtime code.
  5. Finalized node names as following:
    1. zero - live parachain node, which will be used to run on Polkadot. It does not contain GameDAO/Zero pallets.
    2. subzero - dev parachain node, used to run dev/test/stage environments. Contains all pallets.
    3. subzero-standalone - dev standalone node. May be used for local development/testing. Contains all pallets.

Discussed questions:

  • Implement feature flags to build appropriate node/runtime (as separate task)
  • Add rmrk pallet to dev runtime add rmrk2 pallets to parachain #119, once tested also add it to clean (live) runtime

@vayesy vayesy requested review from 2075 and vovacha September 26, 2022 20:32
@vayesy vayesy self-assigned this Sep 26, 2022
@vayesy vayesy marked this pull request as ready for review September 28, 2022 22:18
@vayesy vayesy added this to the P1 parachain setup complete milestone Sep 29, 2022
@vayesy vayesy marked this pull request as draft September 29, 2022 19:31
@vayesy vayesy marked this pull request as ready for review September 29, 2022 20:15
Copy link
Contributor

@vovacha vovacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, this naming makes sense!
0️⃣ 🚀

Copy link
Member

@2075 2075 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@2075 2075 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would make sense to have the two address spaces reflected here, afair 23 and 24? 23 subzero 24 zero?

@vayesy
Copy link
Member Author

vayesy commented Sep 30, 2022

@2075 we can do that in chain spec file if needed. This might be good idea to differentiate but can also cause some issues (at the beginning) due to address format mismatch.

@vayesy vayesy merged commit 45045ac into dev Sep 30, 2022
@vayesy vayesy deleted the feature/clean-parachain-runtime branch September 30, 2022 09:45
@vayesy vayesy mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants