Create parachain runtime excluding Zero/GameDAO pallets#90
Create parachain runtime excluding Zero/GameDAO pallets#90vayesy wants to merge 1 commit intorelease-3.1.61from
Conversation
|
did you decide it is faster to build a lean one and then new features are added step by step and added via feature flags? @vasylenko-yevhen |
| @@ -0,0 +1,101 @@ | |||
| [package] | |||
| name = "parachain-subzero-node" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
| version = "0.1.0" | |
| version = "3.1.60" |
There was a problem hiding this comment.
Or should it start from 0? We have release-3.1.60 and parachain's runtime version is 0.1.0. A bit confusing.
There was a problem hiding this comment.
Versioning approach is not clear to me for this runtime. Since it does not contain any Zero/GameDao features/pallets, is there any sense following same versioning now?
I was thinking of setting up correct version number at the moment, when we would enable these pallets in the runtime and leave it 0.1.0 for now, like a pre-release.
What's your opinion on that?
There was a problem hiding this comment.
-
the versioning for runtime / node can be separate from zero pallets and gamedao pallets.
-
also we need to come up with a release plan where we show node / runtime version x has zero / gamedao pallets y,z,a,b,...
-
the
version 1as discussed for the stable env, how would that relate to the parachain versioning now? we should discuss maybe.
| @@ -0,0 +1,175 @@ | |||
| [package] | |||
| name = "parachain-subzero-runtime" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
| version = "0.1.0" | |
| version = "3.1.60" |
|
Feature flags are good to have, however I think we should work on them at a later stage. There are few reasons why:
I would suggest to skip feature flags for now and start working on them just before we would release official first version.
the stable staging could get a complete end to end build with stuff tagged stable and matching versions. @vasylenko-yevhen @vovacha @DarkNebula0 |
0b68ffd to
7585360
Compare
2075
left a comment
There was a problem hiding this comment.
should we separate builds by creating n names and folders or by tagging properly and maintaining one consistent codebase?
Nobody suggested changes or splitting stuff. Could you elaborate on this?
What's the context? It's an external dependency.
It already works like that with the release tag except for the voting, no?
Could you elaborate on this? Not clear what's the suggestion about.
Sounds good. So far, we have only a release tag, but it's not clear if this release is stable or not. @2075 or @vasylenko-yevhen? |
7585360 to
bdcbbd6
Compare
No description provided.