Heatmap Padding#868
Conversation
Add padding field to heatmap that allows users to define space between bricks.
|
@CalvinFernandez Thanks so much for this PR! Looks like mocks Also, looks like jasmine test If you have any questions about the two points above ⬆️ please let me know. |
|
@CalvinFernandez tests are passing, this PR is looking great. I just thought about one little detail that should be fixed before merging. Right now, For example: var data = [{ y: [2,1,2], mode: 'markers', line: { shape: 'spline' } }];
Plotly.validate(data);
// => In data trace 0, container line did not get coercedTo do so, corce var zsmooth = coerce('zsmooth');
if(zsmooth === false) {
coerce('xgap');
coerce('ygap');
}Thanks again for your efforts 🍻 |
|
Amazing PR. Thank you very much 🍻 |
Add
xgapandygapfield to heat map that allows users to define space between bricks.closes #868