tried to fix default renderer for ipython terminal

[emmanuelle]

Closes #2254

I'm not sure yet whether this is the right place to add the check for the terminal. Also need to check tests.

[jonmmease]

Thanks for taking a look at this @emmanuelle. As I recall, I didn't come up with a good way to distinguish the ipython console from a jupyter notebook kernel. Have you checked that this codepath is not triggered in a notebook context?

[emmanuelle]

Hi @jonmmease I gave it a try on my laptop, also on Colab and in Kaggle.

from plotly import optional_imports
ipython = optional_imports.get_module("IPython")
print(ipython.get_ipython().__class__.__name__)

returns ZMQInteractiveShell with my version of the notebook and in Kaggle, and Shell in Colab.

Given the fact that the Ipython terminal is a small fraction of our marker (however, with a strong bias towards experimented developers!), I understand we need to be cautious here and be sure not to break anything for notebook-like environments. This is also why I put this test after all the ones checking environments variables. Do you have any suggestion on how to test systematically whether this change does not break anything?

[jonmmease]

Thanks for investigating! That all sounds good. 💃 from me