Skip to content

tried to fix default renderer for ipython terminal #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmanuelle merged 2 commits into from
Mar 11, 2020
Merged

tried to fix default renderer for ipython terminal #2255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
574c59f
tried to fix default renderer for ipython terminal
emmanuelle Mar 6, 2020
bf62f47
refactoring
emmanuelle Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/python/plotly/plotly/io/_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,12 @@ def show(fig, renderer=None, validate=True, **kwargs):
# orca not found
pass

# Check if we're running in ipython terminal
if not default_renderer and (
ipython.get_ipython().__class__.__name__ == "TerminalInteractiveShell"
):
default_renderer = "browser"

# Fallback to renderer combination that will work automatically
# in the classic notebook (offline), jupyterlab, nteract, vscode, and
# nbconvert HTML export.
Expand Down