Fix standalone service compilation#77
Closed
mauriciovasquezbernal wants to merge 1 commit intopolycube-network:masterfrom
Closed
Fix standalone service compilation#77mauriciovasquezbernal wants to merge 1 commit intopolycube-network:masterfrom
mauriciovasquezbernal wants to merge 1 commit intopolycube-network:masterfrom
Conversation
Wrong spdlog library includes were causing a compilation failure for standalone services. Fixes: 9d00993 ("create base cube") Signed-off-by: Mauricio Vasquez B <mauriciovasquezbernal@gmail.com>
mauriciovasquezbernal
force-pushed
the
pr/fix_standalone_service_compilation
branch
from
cc10df2 to
dd6b7c5
Compare
frisso
approved these changes
Mar 9, 2019
Contributor
|
@mauriciovasquezbernal I see the label |
Contributor
Author
|
I think this is still incomplete, so hold this for now. |
Contributor
Author
|
This solution is just a workaround, so I prefer to close it until we implement a proper solution for this problem: #91. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the compilation of standalone services.