Conversation
|
You might want to comment on the approach here. I think you can already see that you get a lot “for free” (or nearly so) doing it this way. I’m planning tests for all the above. So, quite neat, but not a lot to see here. The PR doesn’t show it, but I’ve already confirmed that this delivers identical results for a lot of cases |
…xperimental code.
a9d35df to
3db2218
Compare
lib/iris/fileformats/pp.py
Outdated
|
|
||
|
|
||
| _DO_STRUCTURED_LOAD = False | ||
| _STRUCTURED_LOAD_IS_RAW = False |
There was a problem hiding this comment.
NOTE: #29 contains a neater solution to the 'load_raw' problem
|
I am happy with the approach here; I suggest you keep this branch open and merge things onto this as we work through the details then this branch can form the PR to the Scitools/iris master |
Structured load api moretests
Thread-safe structured-loading control.
Transplant code from, and remove dependency on, iris.experimental.fieldsfile
|
I like the implementation as a context manager, I think this is a neat way to provide the functionality for people to opt into @bjlittle do you agree that htis is a useful way to present this to users? |
Revised documentation, whatsnew and deprecations.
|
Status change: As everything else was already agreed + merged to here, I've merged the outstanding #31 here, as that is all that remains to discuss. |
* Updated the branding and execution of Iris This includes: * removing the "easy-to-use" statement in Iris' strapline. Let's let users be the judge of that. * improved the styling of the homepage, including re-instating the search bar. * Added a what's new for SciTools#3010. * Added a extlinks section for convenient linking to github issues with :issue:`number` and :pr:`number`. * Added a favicon for the docs. * Improve strapline style, content (#27) * Further improvements to Iris docs * Improved font (noto-sans) * Removed old CSS * Fixed a few what's new entries
Basic provision of a public API for "fast" (i.e. structured) pp + ff loading.
This works via a context manager that enables fast-load for all the iris load functions.
At this point there is no public low-level interface to this functionality, equivalent to the pp or grib
as_pairsfunctions. It would be fairly easy to add one, but it's not a priority.