Skip to content

Structured load api#27

Closed
pp-mo wants to merge 26 commits intostructured_load_api_BASEPOINTfrom
structured_load_api
Closed

Structured load api#27
pp-mo wants to merge 26 commits intostructured_load_api_BASEPOINTfrom
structured_load_api

Conversation

@pp-mo
Copy link
Owner

@pp-mo pp-mo commented Nov 4, 2016

Basic provision of a public API for "fast" (i.e. structured) pp + ff loading.

This works via a context manager that enables fast-load for all the iris load functions.

At this point there is no public low-level interface to this functionality, equivalent to the pp or grib as_pairs functions. It would be fairly easy to add one, but it's not a priority.

@pp-mo
Copy link
Owner Author

pp-mo commented Nov 4, 2016

@marqh @bjlittle

You might want to comment on the approach here.

I think you can already see that you get a lot “for free” (or nearly so) doing it this way.
I reckon the key ‘similarities to standard load’ which this should deliver are :
• multiple sourcefiles
• filename and uri expansion
• constraints
• callbacks
• post-load merging (especially: building from scalar coords that vary across files, e.g. realization)

I’m planning tests for all the above.
I’m also building a list of ‘known problem cases’, which I may also code as tests.

So, quite neat, but not a lot to see here.
Docs are only stubs so far.
We could easily turn the ‘switch’ into a context manager or load keyword if wanted.

The PR doesn’t show it, but I’ve already confirmed that this delivers identical results for a lot of cases
(and different but OK answers in others).

@pp-mo pp-mo force-pushed the structured_load_api branch from a9d35df to 3db2218 Compare November 8, 2016 14:11


_DO_STRUCTURED_LOAD = False
_STRUCTURED_LOAD_IS_RAW = False
Copy link
Owner Author

@pp-mo pp-mo Nov 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: #29 contains a neater solution to the 'load_raw' problem

@marqh
Copy link

marqh commented Nov 10, 2016

I am happy with the approach here; I suggest you keep this branch open and merge things onto this as we work through the details

then this branch can form the PR to the Scitools/iris master

@pp-mo pp-mo mentioned this pull request Nov 11, 2016
@marqh
Copy link

marqh commented Nov 11, 2016

I like the implementation as a context manager, I think this is a neat way to provide the functionality for people to opt into

@bjlittle do you agree that htis is a useful way to present this to users?

@pp-mo
Copy link
Owner Author

pp-mo commented Nov 14, 2016

Status change: As everything else was already agreed + merged to here, I've merged the outstanding #31 here, as that is all that remains to discuss.
So I closed this and opened a new PR to the main Iris master instead : SciTools#2241
We can discuss what remains to be discussed there.

@pp-mo pp-mo closed this Nov 14, 2016
pp-mo pushed a commit that referenced this pull request Jul 26, 2018
* Updated the branding and execution of Iris

This includes:

 * removing the "easy-to-use" statement in Iris' strapline. Let's let users be the judge of that.
 * improved the styling of the homepage, including re-instating the search bar.
 * Added a what's new for SciTools#3010.
 * Added a extlinks section for convenient linking to github issues with :issue:`number` and :pr:`number`.

* Added a favicon for the docs.

* Improve strapline style, content (#27)

* Further improvements to Iris docs

* Improved font (noto-sans)
* Removed old CSS
* Fixed a few what's new entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants