This repository was archived by the owner on Mar 28, 2019. It is now read-only.
Conversation
Contributor
JayH5
commented
Jul 11, 2016
JayH5
commented
- Fix two versions of pip being installed, and add a basic test to ensure the pip version we request is the pip version we get docker-library/python#121
- Add "--enable-loadable-sqlite-extensions" for 3.x versions docker-library/python#125
* Update Python 2.7 cleanup command
| \) -exec rm -rf '{}' + \ | ||
| && apk del .fetch-deps \ | ||
| && rm -rf /usr/src/python | ||
| && rm -rf /usr/src/python ~/.cache |
Member
There was a problem hiding this comment.
Is it worth making this giant thing a script? I suppose then we'd end up with it in the image, but that's probably not the worst thing in the world.
Contributor
Author
There was a problem hiding this comment.
Probably could. At the moment this tracks the upstream script as closely as possible (https://github.com/docker-library/python/blob/master/2.7/alpine/Dockerfile). That's a big RUN && script so I'd like to keep it like that... but there's not a huge difference between this and a script I guess.
Member
|
👍, although we'll need another review if you make the change I mentioned in the comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.