Sharethrough adapter to use ajax#1042
Merged
Conversation
This was referenced Mar 9, 2017
mkendall07
approved these changes
Mar 21, 2017
Contributor
protonate
approved these changes
Mar 21, 2017
Collaborator
protonate
left a comment
protonate
left a comment
There was a problem hiding this comment.
Looks good, tests green, approved.
Contributor
Author
|
#1069 We added another PR because we realized we weren't sending cookies to our bidder endpoint. |
vzhukovsky
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 29, 2017
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 6, 2017
…nc-with-aol-github to aolgithub-master * commit '0c6c83cc2bfaeeafa9da967c90d83da4af58e7b3': Add change log entry. Renaming and fix missing semicolon. Update parsing script tag regexp. Refactoring. Replace stub bids objects, add additional case for rendering pixels. Refactoring. Replace test consts by methods. Create separate namespace for aol globals, add unit tests. Fix unit tests, remove unnecessary spaces. Implement render pixels only once feature. Add change log entry. Add reporting ID for analytics. Add Facebook Audience Network adapter fix specs update version fix jslint errors Change to using a closure for the callback from ajax to preserve bidObj Ensure cookies get sent in request headers (prebid#1069) Rz/ajax (#5) (prebid#1042)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
update sharethrough adapter to use ajax for bid requests instead of iframes in order to speed up bid response times.
N/A
rzhang@sharethrough.com
Other information