Skip to content

Sharethrough adapter - Ensure cookies get sent in request headers#1069

Merged
mkendall07 merged 1 commit intoprebid:masterfrom
sharethrough:rz_pk/ajax_cookie
Mar 23, 2017
Merged

Sharethrough adapter - Ensure cookies get sent in request headers#1069
mkendall07 merged 1 commit intoprebid:masterfrom
sharethrough:rz_pk/ajax_cookie

Conversation

@rizhang
Copy link
Contributor

@rizhang rizhang commented Mar 22, 2017

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Add withCredentials: true to the AJAX call to make sure cookies get sent correctly

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Other information

* Add "withCredentials" to the AJAX call to make sure cookies get sent
* correctly
@rizhang rizhang changed the title Ensure cookies get sent in request headers Sharethrough adapter - Ensure cookies get sent in request headers Mar 22, 2017
@rizhang rizhang mentioned this pull request Mar 22, 2017
9 tasks
@mkendall07
Copy link
Contributor

LGTM.

@mkendall07 mkendall07 merged commit cb6cd4b into prebid:master Mar 23, 2017
vzhukovsky pushed a commit to aol/Prebid.js that referenced this pull request Apr 29, 2017
* Add "withCredentials" to the AJAX call to make sure cookies get sent
* correctly
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 6, 2017
…nc-with-aol-github to aolgithub-master

* commit '0c6c83cc2bfaeeafa9da967c90d83da4af58e7b3':
  Add change log entry.
  Renaming and fix missing semicolon.
  Update parsing script tag regexp.
  Refactoring. Replace stub bids objects, add additional case for rendering pixels.
  Refactoring. Replace test consts by methods.
  Create separate namespace for aol globals, add unit tests.
  Fix unit tests, remove unnecessary spaces.
  Implement render pixels only once feature.
  Add change log entry.
  Add reporting ID for analytics.
  Add Facebook Audience Network adapter
  fix specs
  update version
  fix jslint errors
  Change to using a closure for the callback from ajax to preserve bidObj
  Ensure cookies get sent in request headers (prebid#1069)
  Rz/ajax (#5) (prebid#1042)
@jchau87 jchau87 deleted the rz_pk/ajax_cookie branch June 21, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments