replace broken utils.extend functionality with object.assign

[snapwich]

Type of change

• Bugfix

Description of change

The utils#extend functionality was erroneously converting array properties in the source object to plain objects in the target object. I found this bug when attempting to loop over the bidderRequest.bids array in a BID_REQUESTED event handler and saw that events.getEvents() was converting the bids array into a plain object.

Since Object.assign is available in Babel I removed utils.extend and replaced with Object.assign in every place I could find. Object.assign also has the added benefit of allowing multiple sources.

[mkendall07]

why copy here?

[snapwich]

for whatever reason, just replacing utils.extend with Object.assign was causing the tests to fail. I think they were built in away that made them dependent on the broken utils.extend functionality. I didn't do a deep-dive to figure out why they were failing, but I noticed that the intent was to have a fresh request object before each unit test; copy worked without breaking the tests.

[snapwich]

Also, Object.assign({}, request, BIDDER_REQUEST) did not work either.

[snapwich]

@mkendall07 Coincidentally a co-worker's build was breaking today because the AOL adapter spec was requiring lodash for cloneDeep. lodash isn't listed as a direct dependency in the package.json but is an indirect dependency of some other library. This was causing the build to break on npm v2, but not v3 (which flattens the dependency tree and does dependency resolution).

I just updated this pull-request and added that copy function as a utility function, utils.cloneDeep , and updated both the calls in the lifestreet_spec and aol_spec to use it.

[mkendall07]

@snapwich whoa, good find.
Maybe call it utils.cloneByJsonParse or something, just to discourage use. cloneDeep sounds like it should copy everything, but parse drops functions.

[snapwich]

That's a good call. I've updated it to be called cloneJson

[matthewlane]

👍