Update Roxot prebid analytic adapter by kir-roxot · Pull Request #1034 · prebid/Prebid.js

kir-roxot · 2017-03-07T14:43:39Z

Feature

Description of change

Hi Guys,

We have changed our analytics adapter logics. AUCTION_END and REQUEST_BIDS events were also added in AnalyticsAdapter to get it full.

…ot_prebid_analytic

kir-roxot · 2017-03-13T16:09:13Z

@matthewlane @mkendall07 Hi guys, i've added test publisher for you. You can test analytic that sent at our endpoint with this config, and you will get 200 ok response:

pbjs.que.push(function () {
  pbjs.enableAnalytics({
    provider: 'roxot',
    options: {
      publisherIds: ['bea17352-fb94-490d-b206-45096c96dbbc']
    }
  });
});

…ot_prebid_analytic

matthewlane · 2017-03-24T16:31:17Z

package.json

  ],
  "globalVarName": "pbjs",
-  "analytics": [],
+  "analytics": ["roxot_prebid_analytic"],


The analytics array should still be empty by default

matthewlane · 2017-03-24T16:48:46Z

src/adapters/analytics/roxot.js

+  eventStack.events = [];
+}
+
+let roxotAdapter = utils.extend(adapter({url, analyticsType}),


Object.assign should work here as utils.extend was recently removed in #1055

matthewlane · 2017-03-24T17:02:23Z

test/spec/roxot_analytic_spec.js

@@ -0,0 +1,35 @@
+let assert = require('assert');


Assertions aren't used in this test?

matthewlane · 2017-03-24T18:51:47Z

src/adapters/analytics/roxot.js

+        return;
+      }
+
+      args.ad = "";


Probably best to check for the existence of args first, if args is undefined this causes a TypeError originating in event.js to be thrown

matthewlane · 2017-03-27T20:57:42Z

test/spec/roxot_analytic_spec.js

@@ -1,4 +1,3 @@
-let assert = require('assert');
 let analytic = require('../../src/adapters/analytics/roxot');


For the assertions, was meaning that the test doesn't check for anything in it's current state. As it's structured could check that the track function was called in response to the emitted events. This can be done by setting up a sinon spy before the emits with sinon.spy(analytic, 'track');, then after the emits something like sinon.assert.callCount(analytic.track, 7);. To make this work the analytic import here would need to change to use ES2015 import statement, or to let analytic = require('../../src/adapters/analytics/roxot').default; because of how the default export is compiling. Feel free to test this according to your preferences though

Also please move this into the analytics test directory at test/spec/adapters/analytics, thanks

…ot_prebid_analytic

…ture/roxot_prebid_analytic

kir-roxot · 2017-04-10T15:21:07Z

Hey @matthewlane !

We added the tests you described.
Is it possible to jump the queue and release our updated analytics adapter as soon as possible?

Currently, the adapter on http://prebid.org/download.html is outdated and doesn't collect data as it is supposed to. We are concerned that publishers might be confused as the old version of our adapter doesn't work as described.

matthewlane · 2017-04-10T20:28:56Z

Thanks for the tests. We'll get the PR merged as soon as possible. There's not currently a plan to do a patch release but it would be included whenever the next release is

matthewlane · 2017-04-10T18:20:54Z

package.json

-    "array.prototype.find": "^2.0.3"
+    "array.prototype.find": "^2.0.3",
+    "babel-cli": "^6.24.1",
+    "babel-preset-node6": "^11.0.0"


Why were babel-cli and babel-preset-node6 added as dependencies, I don't think they're used anywhere?

…ture/roxot_prebid_analytic

kir-roxot · 2017-04-11T09:31:22Z

@matthewlane Sorry, fixed.

protonate

Looks good, adapter is sending analytics data, though the POST response is 403, perhaps the test publisher id is stale.

Ship it!

…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...

Апухтин Кирилл and others added 19 commits September 15, 2016 17:47

add roxot adapter

6101172

Merge remote-tracking branch 'upstream/master'

4406098

Merge branch 'master' of github.com:prebid/Prebid.js

08039e2

update roxot analytics system

992c981

Merge branch 'master' of github.com:prebid/Prebid.js

752422c

remove unused test

d098b41

remove unused import

c230290

Merge branch 'master' of github.com:prebid/Prebid.js

7ce1d58

update code after review

3f34fac

Merge branch 'master' of github.com:prebid/Prebid.js

4d68205

Merge branch 'master' of github.com:prebid/Prebid.js

993e6f1

Merge branch 'master' of github.com:prebid/Prebid.js

3552515

add analytic adapter - roxot prebid analytic

699c6fc

Update roxot prebid analytic

e4449de

update

cf3c480

Fix tests

0d9cf48

Merge branch 'master' of github.com:prebid/Prebid.js into feature/rox…

1f49842

…ot_prebid_analytic

Fix Roxot tests

9a20ee0

Fix endpoint

6830f74

kir-roxot changed the title ~~Update roxot prebid analytic adapter~~ Update Roxot prebid analytic adapter Mar 14, 2017

Register config only once.

946e149

mkendall07 assigned matthewlane Mar 20, 2017

matthewlane added the needs review label Mar 20, 2017

kir-roxot added 2 commits March 22, 2017 16:25

Clear ad parameter for optimize traffic

4b06cb7

Merge branch 'master' of github.com:prebid/Prebid.js into feature/rox…

645d10c

…ot_prebid_analytic

matthewlane self-requested a review March 24, 2017 16:05

matthewlane reviewed Mar 24, 2017

View reviewed changes

matthewlane added needs update and removed needs review labels Mar 24, 2017

Fix after review

ae802d0

matthewlane reviewed Mar 27, 2017

View reviewed changes

kir-roxot and others added 5 commits April 5, 2017 17:56

Merge branch 'master' of github.com:prebid/Prebid.js into feature/rox…

a2762e9

…ot_prebid_analytic

Fix remove ad from global object

f3ed3f7

Add tests.

f7c3eab

Merge branch 'master' of https://github.com/prebid/Prebid.js into fea…

c608729

…ture/roxot_prebid_analytic

Remove request_bids event from AnalyticsAdapter.js

8702ba3

matthewlane reviewed Apr 10, 2017

View reviewed changes

Aleksandr-roxot added 2 commits April 11, 2017 12:18

Remove extra dependencies

b6ac875

Merge branch 'master' of https://github.com/prebid/Prebid.js into fea…

b1dcfdf

…ture/roxot_prebid_analytic

matthewlane removed the needs update label Apr 11, 2017

matthewlane approved these changes Apr 11, 2017

View reviewed changes

matthewlane added the LGTM label Apr 11, 2017

protonate approved these changes Apr 13, 2017

View reviewed changes

matthewlane merged commit 2a7298f into prebid:master Apr 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Roxot prebid analytic adapter#1034

Update Roxot prebid analytic adapter#1034
matthewlane merged 30 commits intoprebid:masterfrom
roxot-team:feature/roxot_prebid_analytic

kir-roxot commented Mar 7, 2017 •

edited

Loading

Uh oh!

kir-roxot commented Mar 13, 2017

Uh oh!

matthewlane Mar 24, 2017

Uh oh!

matthewlane Mar 24, 2017

Uh oh!

matthewlane Mar 24, 2017

Uh oh!

matthewlane Mar 24, 2017

Uh oh!

matthewlane Mar 27, 2017

Uh oh!

kir-roxot commented Apr 10, 2017

Uh oh!

matthewlane commented Apr 10, 2017

Uh oh!

matthewlane Apr 10, 2017

Uh oh!

kir-roxot commented Apr 11, 2017

Uh oh!

protonate left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

		@@ -1,4 +1,3 @@
		let assert = require('assert');
		let analytic = require('../../src/adapters/analytics/roxot');

Conversation

kir-roxot commented Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of change

Uh oh!

kir-roxot commented Mar 13, 2017

Uh oh!

matthewlane Mar 24, 2017

Choose a reason for hiding this comment

Uh oh!

matthewlane Mar 24, 2017

Choose a reason for hiding this comment

Uh oh!

matthewlane Mar 24, 2017

Choose a reason for hiding this comment

Uh oh!

matthewlane Mar 24, 2017

Choose a reason for hiding this comment

Uh oh!

matthewlane Mar 27, 2017

Choose a reason for hiding this comment

Uh oh!

kir-roxot commented Apr 10, 2017

Uh oh!

matthewlane commented Apr 10, 2017

Uh oh!

matthewlane Apr 10, 2017

Choose a reason for hiding this comment

Uh oh!

kir-roxot commented Apr 11, 2017

Uh oh!

protonate left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

kir-roxot commented Mar 7, 2017 •

edited

Loading