Add alias freewheel-ssp to stickyadstv bidder adapter #1043
Merged
matthewlane merged 24 commits intoprebid:masterfrom Apr 3, 2017
Merged
Add alias freewheel-ssp to stickyadstv bidder adapter #1043matthewlane merged 24 commits intoprebid:masterfrom
matthewlane merged 24 commits intoprebid:masterfrom
Conversation
added 23 commits
January 5, 2017 10:21
Contributor
|
LGTM. |
matthewlane
approved these changes
Apr 3, 2017
outoftime
added a commit
to Genius/Prebid.js
that referenced
this pull request
Apr 19, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 19, 2017
…19.0 to aolgithub-master * commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits) Disable unit tests that fails on PhantomJs. Fixed unit tests for adapter loader. Changed way of including analytic adapters. Added adapters in aolPartnersIds.json. Added changelog entry. Replace removed utils.extend functionality by object.assign. Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) Updated rubicon video bid endpoint in source and test files (prebid#1097) Pass through params to server (prebid#1084) Reset the list of slots to be requested between each action for pubmatic (prebid#1079) Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021) update PR template to include link to dev docs page (prebid#1075) Prebid 0.21.0 Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054) Video header bidding support to RhythmOne bidder adapter (prebid#1052) Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045) Fix adapter getSize (prebid#1064) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
As new may know StickyAdsTV is now FreeWheel (www.stickyads.tv)
So I've made changes to use the alias freewheel-ssp pointing to the stickyadstv bidder adaptor
contact email of the adapter’s maintainer
gandouard@freewheel.tv
[x ] official adapter submission
Other information
Test page: http://sandbox.stickyadstv.com/qa/prebid.html
We are using prebid to serve inbanner video ads and we are wondering if this case is concerned by the 20$ CPM CAP?
(http://prebid.org/dev-docs/show-video-with-a-dfp-video-tag.html#implement-custom-price-buckets-to-work-around-the-default-cpm-cap-of-20)
When I run tests using a price over 20$ everything seems fine.
If we need to work around this, can we do it from inside the bidder adapter or is the "custom price bucket" something the publisher needs to setup?