Conversation
protonate
force-pushed
the
improvement/yarn
branch
from
2aa9f9c to
6949788
Compare
mkendall07
suggested changes
Apr 7, 2017
yarn.lock
Outdated
|
|
||
| ansi-escape-sequences@^3.0.0: | ||
| version "3.0.0" | ||
| resolved "https://npm.corp.appnexus.com/ansi-escape-sequences/-/ansi-escape-sequences-3.0.0.tgz#1c18394b6af9b76ff9a63509fa497669fd2ce53e" |
Contributor
There was a problem hiding this comment.
Looks to be a lot of internal npm references here. Need to fix.
Collaborator
Author
There was a problem hiding this comment.
oh I see you mean anx internal npm registry, yep got it.
Do you mean npm registry references? That is expected, Yarn is an npm registry client, not a replacement. registry.yarnpkg.com is a proxy for registry.npmjs.org.
Collaborator
Author
|
@mkendall07 better now |
mkendall07
approved these changes
Apr 10, 2017
Contributor
|
LGTM. |
Contributor
|
@snapwich |
snapwich
approved these changes
Apr 13, 2017
| **Build standalone prebid.js** | ||
|
|
||
| - Clone the repo, run `npm install` | ||
| - Clone the repo, run `yarn install` |
Collaborator
There was a problem hiding this comment.
Might want to add a link to the yarn project for those that are unfamiliar with it.
added 4 commits
April 13, 2017 13:57
protonate
force-pushed
the
improvement/yarn
branch
from
22cf680 to
538f6f4
Compare
Collaborator
Author
|
Note addressed, thanks for reviews. |
outoftime
added a commit
to Genius/Prebid.js
that referenced
this pull request
Apr 19, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds the Yarn package manager. NOTE: Yarn must be installed independently of this change and as fits the developer's environment. See install guide.
Usage is similar to NPM.