Add new Adapter- Beachfront Media by Allen-37F · Pull Request #1062 · prebid/Prebid.js

Allen-37F · 2017-03-21T23:46:08Z

Type of change

Description of change

test parameters for validating bids

{
  	bidder: 'beachfront',
           params: {
              bidfloor: .01,
              appId: "11bc5dd5-7421-4dd8-c926-40fa653bec76"
          	}
        	}
        ]
}

contact email of the adapter’s maintainer:
Repository Management - [John Salis] johnsalis@beachfrontmedia.com
Operational Publisher Contact - [Anthony Campanella] anthony@beachfrontmedia.com

Other information

… for prebid.js pull request

# Conflicts: # src/adapters/beachfront.js

* temp: Ready for pull request with prebid.js

* commit '0cea31cd294f380b3b7cf46dd7a4000316b71ac1': Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023)

…bid_pr

aneuway2 · 2017-03-22T21:08:59Z

Hey @Allen-37F are bidFloor and appId both required parameters for your adaptor? Might be good to submit a PR to have this documented :-)

https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders

Allen-37F · 2017-03-23T16:52:06Z

Yes, those are the two required params. Thanks for the tip - added a .md documenting that.

snapwich · 2017-04-11T18:57:36Z

Thanks for the test page comment. It should not be a part of the pull-request commits though, sorry if I was confusing.

Allen-37F · 2017-04-11T20:08:24Z

Roger that - deleted index.html from the pull request

Allen-37F

I hope this did the trick!

snapwich · 2017-04-13T17:03:01Z

LGTM 👍

mkendall07 · 2017-04-17T16:26:43Z

src/adapters/beachfront.js

+      var newBid = {};
+      newBid.price = parsed.bidPrice;
+      newBid.url = parsed.url;
+      newBid.bidId = utils.getUniqueIdentifierStr();


The bidId should be from the request bid - see https://github.com/prebid/Prebid.js/blob/master/src/adapters/appnexus.js#L200 for example. This is to sync the request/response.

mkendall07 · 2017-04-17T16:28:52Z

@Allen-37F please update the code for handling the bid.bidId and then we can mrege.
@snapwich not sure if the bug you referring to relates to the bid ID not matching or not.

snapwich · 2017-04-17T16:51:22Z

@mkendall07 I don't think it's related, but that's a good catch.

mkendall07 · 2017-04-18T01:23:26Z

LGTM.

mkendall07 · 2017-04-18T01:24:25Z

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

Allen-37F · 2017-04-18T15:14:55Z

Thanks, everyone! The PR to have Beachfront added to the bidders directory is #203, and it's ready.

…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...

Allen-37F and others added 25 commits February 20, 2017 18:15

init

06ad614

Merge branch 'master' of https://github.com/Allen-37F/Prebid.js

494b984

refactoring and replacing hard-coded variables

a9d0c21

changed error handling if missing adid or bidfloor

2b9d2ee

created testing spec for beachfront adapter & began writing unit tests

5a8a22e

working on testing

a027614

still testing

d37a1f8

all tests passing but the last two. Almost there...

8797904

getting ready to change to new getmu response

494f428

adapter working, tests complete; removing console logs and setting up…

2ef8413

… for prebid.js pull request

only the beachfront adapter plus prebidvid.html

79feb7d

merging with upstream master

e517f05

Added adapter for Beachfront and associated tests.

0990e13

updating adapter

179cf87

Merge commit '179cf87360d0a5e03ed6cdb28b608571c958d45b' into bfAdapter

e51e7cf

# Conflicts: # src/adapters/beachfront.js

Ready for pull request with prebid.js

71e6e6f

Merge branch 'temp'

015510d

* temp: Ready for pull request with prebid.js

Updated ‘dev’ parameter in test request

f650de8

Update params for pull request

985fcad

Pointing to prod endpoint in adapter and test

4a7668f

Stage adapter files for prebid pull request

3d3f90e

Retrying commit of adapter files for PR

c4263f2

Merge branch 'master' of https://github.com/prebid/Prebid.js into pre…

ce73cd8

…bid_pr

last-minute

b5d9852

Allen-37F changed the title ~~Prebid pr~~ Add new Adapter- Beachfront Media Mar 27, 2017

mkendall07 requested a review from snapwich March 31, 2017 15:30

Merge branch 'master' into prebid_pr

caa0e27

Deleted index.html

81f3c21

Allen-37F commented Apr 12, 2017

View reviewed changes

snapwich approved these changes Apr 13, 2017

View reviewed changes

snapwich added LGTM and removed needs update labels Apr 13, 2017

ndhimehta added needs update ready in progress and removed LGTM ready in progress labels Apr 13, 2017

mjacobsonny added the video label Apr 14, 2017

snapwich added LGTM and removed needs update labels Apr 14, 2017

mkendall07 suggested changes Apr 17, 2017

View reviewed changes

updated newBid.bidId

f76c1fa

mkendall07 approved these changes Apr 18, 2017

View reviewed changes

mkendall07 merged commit e532d09 into prebid:master Apr 18, 2017

mkendall07 removed the ready label Apr 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new Adapter- Beachfront Media#1062

Add new Adapter- Beachfront Media#1062
mkendall07 merged 34 commits intoprebid:masterfrom
Allen-37F:prebid_pr

Allen-37F commented Mar 21, 2017 •

edited

Loading

Uh oh!

aneuway2 commented Mar 22, 2017

Uh oh!

Allen-37F commented Mar 23, 2017

Uh oh!

snapwich commented Apr 11, 2017

Uh oh!

Allen-37F commented Apr 11, 2017

Uh oh!

Allen-37F left a comment

Uh oh!

snapwich commented Apr 13, 2017

Uh oh!

mkendall07 Apr 17, 2017

Uh oh!

mkendall07 commented Apr 17, 2017

Uh oh!

snapwich commented Apr 17, 2017

Uh oh!

mkendall07 commented Apr 18, 2017

Uh oh!

mkendall07 commented Apr 18, 2017

Uh oh!

Allen-37F commented Apr 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

Conversation

Allen-37F commented Mar 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

aneuway2 commented Mar 22, 2017

Uh oh!

Allen-37F commented Mar 23, 2017

Uh oh!

snapwich commented Apr 11, 2017

Uh oh!

Allen-37F commented Apr 11, 2017

Uh oh!

Allen-37F left a comment

Choose a reason for hiding this comment

Uh oh!

snapwich commented Apr 13, 2017

Uh oh!

mkendall07 Apr 17, 2017

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Apr 17, 2017

Uh oh!

snapwich commented Apr 17, 2017

Uh oh!

mkendall07 commented Apr 18, 2017

Uh oh!

mkendall07 commented Apr 18, 2017

Uh oh!

Allen-37F commented Apr 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

Allen-37F commented Mar 21, 2017 •

edited

Loading