Bidfluence Adapter#1023
Merged
jaiminpanchal27 merged 10 commits intoprebid:masterfrom Mar 10, 2017
francescocristallo:master
Merged
Bidfluence Adapter#1023jaiminpanchal27 merged 10 commits intoprebid:masterfrom francescocristallo:master
jaiminpanchal27 merged 10 commits intoprebid:masterfrom
francescocristallo:master
Conversation
jaiminpanchal27
requested changes
Mar 6, 2017
Collaborator
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
There was a problem hiding this comment.
Verified the bids. Please address the comments. Thanks
src/adapters/bidfluence.js
Outdated
| window.bfPbjsCB = function (bfr) { | ||
| var bidObject = null; | ||
| if (bfr.cpm > 0) { | ||
| bidObject = bidfactory.createBid(1); |
Collaborator
There was a problem hiding this comment.
Add bid request as second param to match request response pair.
src/adapters/bidfluence.js
Outdated
| bidObject.width = bfr.width; | ||
| bidObject.height = bfr.height; | ||
| } else { | ||
| bidObject = bidfactory.createBid(2); |
Collaborator
There was a problem hiding this comment.
Add bid request as second param to match request response pair.
src/adapters/bidfluence.js
Outdated
| placementCode: bid.placementCode | ||
| }; | ||
| /* jshint ignore:end */ | ||
| var s = document.createElement('script'); |
Contributor
Author
There was a problem hiding this comment.
I didn't use it because I need to set the Id of the new script element as per line 43, seems the loadscript function does not allow it.
Collaborator
There was a problem hiding this comment.
Alright, one question, why would you need an id on script element
Contributor
Author
There was a problem hiding this comment.
It was for legacy code, I spent some time today to fix that. The adapter now loadscript function as requested, all the update requested are complete. Thanks
src/adapters/bidfluence.js
Outdated
| var BidfluenceAdapter = function BidfluenceAdapter() { | ||
|
|
||
| //Callback | ||
| window.bfPbjsCB = function (bfr) { |
Collaborator
There was a problem hiding this comment.
Add callback to
-Changed window with $$PREBID_GLOBAL$$ -Added bid request as second param to match request response pair -Didn't change the loader since does not support custom Id to script element, necessary for our code to work.
jaiminpanchal27
approved these changes
Mar 10, 2017
Collaborator
|
Looks good. Thanks @francescocristallo for the changes |
Collaborator
|
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
* Bidfluence Adapter * Bidfluence adapter * Fixed callback name * Final review * First commit, Test passed * Addressed change request (all but the loader one) -Changed window with $$PREBID_GLOBAL$$ -Added bid request as second param to match request response pair -Didn't change the loader since does not support custom Id to script element, necessary for our code to work. * Update reflecting the adapter changes. * Final review, completed update requests. * Fixed Indentation * Fixed global variable causing validation error.
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: Add GourmetAds AppNexus Alias (prebid#1057) fix issue calling `requestBids();` (prebid#1058) explicit win url response format as pixel (prebid#1001) OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027) better http/s support (prebid#1010) Add a new generated field transactionId to each adunits. (prebid#1040) Update readme (prebid#1053) PulsePoint Lite adapter (prebid#1016) Add new adapter ServerBid (by Adzerk) (prebid#1024) Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023) Update uglify-js version (prebid#1041) Add dev dependencies. hb_adid should be uppercase in all cases (prebid#1037) Add TapSense Header Bidding Adapter and tests (prebid#1004) iOS Referrer fix (prebid#996) Change identification of JavaScript user matching (prebid#1022) Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)
Allen-37F
added a commit
to Allen-37F/Prebid.js
that referenced
this pull request
Mar 21, 2017
* commit '0cea31cd294f380b3b7cf46dd7a4000316b71ac1': Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
-integrations@bidfluence.com
Other information