PulsePoint Lite adapter#1016
Merged
jaiminpanchal27 merged 19 commits intoprebid:masterfrom Mar 15, 2017
pulsepointinc:ET-1850-1
Merged
PulsePoint Lite adapter#1016jaiminpanchal27 merged 19 commits intoprebid:masterfrom pulsepointinc:ET-1850-1
jaiminpanchal27 merged 19 commits intoprebid:masterfrom
pulsepointinc:ET-1850-1
Conversation
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change
ET-1850: Fixing #866
jaiminpanchal27
requested changes
Mar 13, 2017
Collaborator
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
There was a problem hiding this comment.
@anand-venkatraman Please check the comments. Thanks.
src/adapters/pulsepointLite.js
Outdated
Collaborator
There was a problem hiding this comment.
I would recommend using these function utils.getTopWindowUrl() and utils.getTopWindowLocation()
src/adapters/pulsepointLite.js
Outdated
Collaborator
There was a problem hiding this comment.
wrap this in try catch
Contributor
Author
There was a problem hiding this comment.
wrapped in try/catch
src/adapters/pulsepointLite.js
Outdated
Collaborator
There was a problem hiding this comment.
Using const/let is recommended.
Contributor
Author
|
@jaiminpanchal27 Comments addressed. |
jaiminpanchal27
approved these changes
Mar 15, 2017
Collaborator
|
LGTM. Thanks @anand-venkatraman |
Collaborator
|
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing prebid#866 * ET-1850: Adding a "lite" adapter. * Minor fix * Fix for response parsing * Minor changes * Minor changes * Updating JS lib endpoint * Updating JS lib endpoint * addressing review comments * fixing jshint error
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: Add GourmetAds AppNexus Alias (prebid#1057) fix issue calling `requestBids();` (prebid#1058) explicit win url response format as pixel (prebid#1001) OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027) better http/s support (prebid#1010) Add a new generated field transactionId to each adunits. (prebid#1040) Update readme (prebid#1053) PulsePoint Lite adapter (prebid#1016) Add new adapter ServerBid (by Adzerk) (prebid#1024) Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023) Update uglify-js version (prebid#1041) Add dev dependencies. hb_adid should be uppercase in all cases (prebid#1037) Add TapSense Header Bidding Adapter and tests (prebid#1004) iOS Referrer fix (prebid#996) Change identification of JavaScript user matching (prebid#1022) Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Lite version of PulsePoint adapter. The current PulsePoint adapter downloads a JS library, and then executes the bid requests. The Lite adapter does not depend on JS library. This will replace the existing PulsePoint adapter, after comparing the results, in a subsequent release.
Additionally, a minor change to the endpoint of the JS lib for the old Adapter, is also included.