Add new adapter ServerBid (by Adzerk)#1024
Conversation
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
There was a problem hiding this comment.
@GaryKertis Please check the comments. Thanks.
src/adapters/serverbid.js
Outdated
There was a problem hiding this comment.
I would recommend using these function utils.getTopWindowUrl() and utils.getTopWindowLocation()
src/adapters/serverbid.js
Outdated
There was a problem hiding this comment.
Move this to else part. In case you get result, this code is of no use.
src/adapters/serverbid.js
Outdated
There was a problem hiding this comment.
remove extra line breaks in this file.
src/adapters/serverbid.js
Outdated
There was a problem hiding this comment.
Using const/let is recommended.
|
@jaiminpanchal27 I have incorporated these changes. Please let me know if there are any other concerns. Thanks! |
|
@GaryKertis utils.getTopWindowUrl is a function. Check line 54 in serverbid.js |
|
Oops. @jaiminpanchal27 fixed. |
|
LGTM. Thanks @GaryKertis |
|
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
* Wrote initial call logic to make request to serverbid. * Add initial bid response handling logic. * Handle requests and responses, successfully pass to add server, write initial tests. * Clean up pricing and fix tests. * Enable request credentials. * JSHint and JSCS * Incorporate code review comments. * Add function invocation to getTopWindowUrl
…built * 'master' of https://github.com/prebid/Prebid.js: Add GourmetAds AppNexus Alias (prebid#1057) fix issue calling `requestBids();` (prebid#1058) explicit win url response format as pixel (prebid#1001) OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027) better http/s support (prebid#1010) Add a new generated field transactionId to each adunits. (prebid#1040) Update readme (prebid#1053) PulsePoint Lite adapter (prebid#1016) Add new adapter ServerBid (by Adzerk) (prebid#1024) Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023) Update uglify-js version (prebid#1041) Add dev dependencies. hb_adid should be uppercase in all cases (prebid#1037) Add TapSense Header Bidding Adapter and tests (prebid#1004) iOS Referrer fix (prebid#996) Change identification of JavaScript user matching (prebid#1022) Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)
2 participants
Type of change
Description of change
Add ServerBid (by Adzerk) adapter.
Other information