Add TapSense Header Bidding Adapter and tests by erikchau · Pull Request #1004 · prebid/Prebid.js

erikchau · 2017-02-22T22:21:54Z

Type of change

New bidder adapter

Description of change

Addition of the TapSense Header Bidding Adapter

test parameters for validating bids

{
  bidder: 'tapsense',
  params: {
    ufid: "ZFiAg3MMs6E4KVyIDVbi8165506790392",
    refer: "localhost",
    jsonp: 1,
    ad_unit_id: "5877f75b0118065391b18f8c",
    device_id: "7bd153d3-8e9f-4bae-a4b3-751614d788b5",
    lat: "47.5643",
    long: "-122.151",
    scriptURL: "https://ads04.tapsense.com/ads/mopubad",
    user: "771fc655-6e4e-4bae-a4b6-751614d788b5",
    price_floor: 0.04,
    test: 1
  }
}

contact email of the adapter’s maintainer
amit@tapsense.com
official adapter submission

Other information

erikchau · 2017-03-03T01:21:00Z

Hi @mkendall07, we currently have a publisher waiting to integrate with us, anyway we can help to speed up the merge process?

tagging @amitmanjhi

mkendall07 · 2017-03-06T22:15:37Z

src/adapters/tapsense.js

@@ -0,0 +1,89 @@
+//v0.0.1
+var bidfactory = require('../bidfactory.js');


please use const/let instead of var as appropriate.

mkendall07 · 2017-03-06T22:27:49Z

src/adapters/tapsense.js

+        if (!bid.params.scriptURL) {
+          continue;
+        }
+        var queryString = "?price=true&callback=tapsense.callback_with_price_" + bid.bidId + "&version=" + version + "&";


Prefer string templates here instead of concatenation.

mkendall07 · 2017-03-06T22:29:11Z

src/adapters/tapsense.js

+          continue;
+        }
+        var queryString = "?price=true&callback=tapsense.callback_with_price_" + bid.bidId + "&version=" + version + "&";
+        window.tapsense["callback_with_price_" + bid.bidId] = generateCallback(bid.bidId);


use the the prebid global object $$PREBID_GLOBAL$$ instead of window.

mkendall07 · 2017-03-06T22:33:57Z

src/adapters/tapsense.js

+          if (validParams.indexOf(keys[j]) < 0) continue;
+          queryString += encodeURIComponent(keys[j]) + "=" + encodeURIComponent(bid.params[keys[j]]) + "&";
+        }
+        var scriptURL = bid.params.scriptURL;


can you make scriptUrl static or is it required to be passed in?

mkendall07 · 2017-03-06T22:34:57Z

src/adapters/tapsense.js

+  }
+
+  function generateCallback(bidId){
+    return function(response, price) {


Any reason this is an anonymous function?

mkendall07 · 2017-03-06T22:42:18Z

src/adapters/tapsense.js

+        return;
+      }
+      for (var k = 0; k < bid.sizes.length; k++) {
+        if (creativeSizes.indexOf(bid.sizes[k].join("x")) > -1) {


This fails if the bid.sizes is a single array and not a nested array (ie [300,250]; instead of [[300,250]];)

mkendall07 · 2017-03-06T22:42:44Z

@erikchau
Can you also mention which params are required and which are optional? Thanks

* changed var to es6 let/const * when checking for bid sizes, use utils.parseSizesInput to handle single/nested arrays * use template strings where applicable * use $$PREBID_GLOBAL$$ instead of window * scriptUrl is now static * named anonymous function in generateCallBack * add more tests in tapsense_spec.js

erikchau · 2017-03-07T01:07:25Z

Name	Scope	Description	Example
`ad_unit_id`	required	Placement ID from TapSense	“ 5877f75b0118065391b18f8c”
`user`	required	User's IDFA	"771fc655-6e4e-4bae-a4b6-751614d788b5"
`refer`	optional	Site that ad request originated from	“https://tapsense.com”
`lat`	optional	Users latitude	“ 47.5643”
`long`	optional	Users longitude	“-122.151”
`price_floor`	optional	Minimum Bid in dollars	“ 0.04”

erikchau · 2017-03-07T01:09:54Z

@mkendall07 ready for re-review
let me know if there is anything else
thanks!

mkendall07 · 2017-03-07T15:13:45Z

src/adapters/tapsense.js

+const TapSenseAdapter = function TapSenseAdapter() {
+  const version = "0.0.1";
+  const creativeSizes = [
+    "320x50"


This is the only valid bid size?

For header bidding we only currently only support banner requests

ok, probably want to make a note about this in your bidder documentation.

Just to be sure, to create our bidder documentation I will need to make a PR for this page with our information correct?? http://prebid.org/dev-docs/bidders.html

mkendall07 · 2017-03-07T15:18:16Z

Thanks for the updates. With the changes, I'm getting
pbjs.tapsense.callback_with_price_26c264cf22f421({"id": "58becf1bda78506f6409a5fb","status": {"value": "error"},"count_ad_units": 0}, 1.2)
Response with specified bid params.

erikchau · 2017-03-07T18:57:47Z

Sorry, should have mentioned that the ad unit id I supplied was for android devices. You will need to set your UA as any android device. Our servers check that the user agent matches the ad unit's platform.

erikchau · 2017-03-08T20:33:49Z

Created bidder documentation PR here: prebid/prebid.github.io#186
Is there anything else left to be done on my end @mkendall07 ?
thanks

mkendall07 · 2017-03-08T20:39:45Z

LGTM. Thanks

* Add TapSense Header Bidding Adapter and tests * Update for Tapsense Prebid Header * changed var to es6 let/const * when checking for bid sizes, use utils.parseSizesInput to handle single/nested arrays * use template strings where applicable * use $$PREBID_GLOBAL$$ instead of window * scriptUrl is now static * named anonymous function in generateCallBack * add more tests in tapsense_spec.js * Url Callback parameter needed prebid global object

…built * 'master' of https://github.com/prebid/Prebid.js: Add GourmetAds AppNexus Alias (prebid#1057) fix issue calling `requestBids();` (prebid#1058) explicit win url response format as pixel (prebid#1001) OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027) better http/s support (prebid#1010) Add a new generated field transactionId to each adunits. (prebid#1040) Update readme (prebid#1053) PulsePoint Lite adapter (prebid#1016) Add new adapter ServerBid (by Adzerk) (prebid#1024) Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023) Update uglify-js version (prebid#1041) Add dev dependencies. hb_adid should be uppercase in all cases (prebid#1037) Add TapSense Header Bidding Adapter and tests (prebid#1004) iOS Referrer fix (prebid#996) Change identification of JavaScript user matching (prebid#1022) Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)

mkendall07 · 2017-03-23T00:48:06Z

@erikchau
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

erikchau · 2017-03-23T01:00:23Z

hi @mkendall07 , this has already been done and merged to master
#1004

mkendall07 · 2017-03-23T01:01:18Z

oh, great. You were fast :) thanks

Add TapSense Header Bidding Adapter and tests

03c9e2c

mkendall07 self-assigned this Mar 1, 2017

mkendall07 suggested changes Mar 6, 2017

View reviewed changes

mkendall07 added the needs update label Mar 6, 2017

Url Callback parameter needed prebid global object

01b2df8

mkendall07 reviewed Mar 7, 2017

View reviewed changes

erikchau mentioned this pull request Mar 8, 2017

Add TapSense Adapter prebid/prebid.github.io#186

Merged

mkendall07 approved these changes Mar 8, 2017

View reviewed changes

mkendall07 merged commit c8b77a3 into prebid:master Mar 8, 2017

erikchau deleted the tapsense_adapter branch March 8, 2017 20:42

		@@ -0,0 +1,89 @@
		//v0.0.1
		var bidfactory = require('../bidfactory.js');

Conversation

erikchau commented Feb 22, 2017

Type of change

Description of change

Other information

Uh oh!

erikchau commented Mar 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Mar 6, 2017

Uh oh!

erikchau commented Mar 7, 2017

Uh oh!

erikchau commented Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Mar 7, 2017

Uh oh!

erikchau commented Mar 7, 2017

Uh oh!

erikchau commented Mar 8, 2017

Uh oh!

mkendall07 commented Mar 8, 2017

Uh oh!

mkendall07 commented Mar 23, 2017

Uh oh!

erikchau commented Mar 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkendall07 commented Mar 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

erikchau commented Mar 7, 2017 •

edited

Loading

erikchau commented Mar 23, 2017 •

edited

Loading