- New Adaptor - Inneractive by uriw-ia · Pull Request #1048 · prebid/Prebid.js

uriw-ia · 2017-03-14T17:56:40Z

Type of change

New bidder adapter

Description of change

New Inneractive PrebidJS Adaptor

test parameters for validating bids

{
  bidder: 'inneractive',
  params: {
    appId: 'Inneractive_Superman_iPhone',
    spotType: 'rectangle',
    customParams: {
      portal: 7002
    }
  }
}

contact email of the adapter’s maintainer
mobileweb@inner-active.com
official adapter submission

Other information

aneuway2 · 2017-03-22T21:23:23Z

Hey @uriw-ia are appId and spotType both required parameters for your adaptor? Might be good to submit a PR to have this documented on prebid.org :-)

https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders

uriw-ia · 2017-03-22T22:33:28Z

Hi @aneuway2,

I've reopened a pull request on https://github.com/prebid/prebid.github.io/ with the documentation
prebid/prebid.github.io#200

(please also see: prebid/prebid.github.io#195).

Thanks,
Uri

matthewlane · 2017-03-24T21:56:01Z

Thanks for the adapter PR. I'm not able to get any bids back with the test parameters, are those still valid?

Also this adapter seems to be doing some analytic reporting, can you describe what's happening there?

uriw-ia · 2017-03-27T09:48:07Z

@matthewlane ,
Could you please try again?
There seems to have been a temporary issue receiving the ad.

Regarding analytics - our adapter is sending out the following events:

"HBPreBidImpression" - for ad impression
"HBPreBidClick" - for ad click
"HBPreBidError" - for adapter JS error (unused)
"HBPreBidNoAd" - for cases in which no ad was received from our servers
"HBNoWin" - for cases in which an ad was received from our servers but didn't eventually win the bid

matthewlane

Thanks for the clarification. We don't allow listening for the BID_WON event in adapters, but the other events you've listed are fine. Was also able to get bid responses with the test params now, thanks

matthewlane · 2017-03-29T23:39:12Z

src/adapters/inneractive.js

+    const _reportNoBidWon = () => this._getStoredBids().forEach(bid => !wonAdIds.includes(bid.adId) && Reporter.reportEvent('HBNoWin', bid.params));
+    let timer = null;
+    $$PREBID_GLOBAL$$.onEvent(EVENTS.AUCTION_END, () => timer = setTimeout(_reportNoBidWon, $$PREBID_GLOBAL$$.bidderTimeout), null);
+    $$PREBID_GLOBAL$$.onEvent(EVENTS.BID_WON, (bid) => {


Please drop this event listener

uriw-ia · 2017-03-30T13:00:32Z

@matthewlane, sure thing.
The method listening for the event and the call to it, have been removed

matthewlane

@uriw-ia I missed one other thing in the initial review, noted below, but after the requested change I think this will be ready for approval. Thanks for the update

matthewlane · 2017-03-30T18:58:22Z

src/adapters/inneractive.js

+ * @type {{defaultsParams: *, serverParamNameBySettingParamName: {referrer: string, keywords: string, appId: string, portal: string, age: string, gender: string, isSecured: (boolean|null)}, toServerParams: (function(*)), unwantedValues: *[], getUrlParams: (function(*=))}}
+ */
+const Url = {
+  defaultsParams: Object.assign({}, Helpers.defaultsQsParams, {f: CONSTANTS.DISPLAY_AD,fs: false,ref: IaWindow.document.referrer}),


Accessing IaWindow.document.referrer here causes Uncaught DOMException: Blocked a frame with origin "<url>" from accessing a cross-origin frame in setups such as the prebid.org example pages. Wrapping this in a try/catch, either in this section, or (if you don't need IaWindow anywhere else), changing lines 34 - 39 to something like

let ref; try{ ref = window.top.document.referrer; }catch(e){ ref = window.document.referrer; }

then setting ref: ref on this line should work, though feel free to catch the exception however you'd prefer

uriw-ia · 2017-04-01T17:25:45Z

@matthewlane, the code is updated based on your comment. Thanks.

mkendall07

LGTM

mkendall07 · 2017-04-03T19:55:09Z

src/adapters/inneractive.js

+   * @param str: string
+   * @returns string
+   */
+  stringToCamel(str){


This would be a good candidate to move to utils at some point.

mkendall07 · 2017-04-03T19:56:22Z

src/adapters/inneractive.js

+   * The returned string is either <code>http://</code> or <code>https://</code>
+   * @returns {string}
+   */
+  getPageProtocol(){


Also good candidate for utils

mkendall07 · 2017-04-03T20:16:16Z

src/adapters/inneractive.js

+ * InnerActiveAdapter for requesting bids
+ * @class
+ */
+class InnerActiveAdapter{


We havne't been pushing to use class but it seems to work ok and transpile.

…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...

…19.0 to aolgithub-master * commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits) Disable unit tests that fails on PhantomJs. Fixed unit tests for adapter loader. Changed way of including analytic adapters. Added adapters in aolPartnersIds.json. Added changelog entry. Replace removed utils.extend functionality by object.assign. Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) Updated rubicon video bid endpoint in source and test files (prebid#1097) Pass through params to server (prebid#1084) Reset the list of slots to be requested between each action for pubmatic (prebid#1079) Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021) update PR template to include link to dev docs page (prebid#1075) Prebid 0.21.0 Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054) Video header bidding support to RhythmOne bidder adapter (prebid#1052) Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045) Fix adapter getSize (prebid#1064) ...

- New Adaptor - Inneractive

40ef073

uriw-ia mentioned this pull request Mar 18, 2017

Inneractive PrebidJS Adaptor Documentation prebid/prebid.github.io#195

Closed

matthewlane self-assigned this Mar 20, 2017

matthewlane added the needs review label Mar 20, 2017

matthewlane self-requested a review March 20, 2017 18:24

matthewlane reviewed Mar 29, 2017

View reviewed changes

refactor: removed checkIfBidWon call and method

4a98b4d

refactor: also removing EVENTS reference from src/constants

423ffb3

matthewlane removed the needs review label Mar 30, 2017

matthewlane reviewed Mar 30, 2017

View reviewed changes

Changed referrer to match access recommendations

663f547

matthewlane approved these changes Apr 3, 2017

View reviewed changes

matthewlane added the LGTM label Apr 3, 2017

matthewlane requested a review from mkendall07 April 3, 2017 17:04

mkendall07 approved these changes Apr 3, 2017

View reviewed changes

matthewlane merged commit c9b2bf4 into prebid:master Apr 3, 2017

uriw-ia mentioned this pull request Apr 10, 2017

docs: adding inneractive.md - Inneractive Adapter Documentation prebid/prebid.github.io#213

Merged

Conversation

uriw-ia commented Mar 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

aneuway2 commented Mar 22, 2017

Uh oh!

uriw-ia commented Mar 22, 2017

Uh oh!

matthewlane commented Mar 24, 2017

Uh oh!

uriw-ia commented Mar 27, 2017

Uh oh!

matthewlane left a comment

Choose a reason for hiding this comment

Uh oh!

matthewlane Mar 29, 2017

Choose a reason for hiding this comment

Uh oh!

uriw-ia commented Mar 30, 2017

Uh oh!

matthewlane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthewlane Mar 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uriw-ia commented Apr 1, 2017

Uh oh!

mkendall07 left a comment

Choose a reason for hiding this comment

Uh oh!

mkendall07 Apr 3, 2017

Choose a reason for hiding this comment

Uh oh!

mkendall07 Apr 3, 2017

Choose a reason for hiding this comment

Uh oh!

mkendall07 Apr 3, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

uriw-ia commented Mar 14, 2017 •

edited

Loading

matthewlane left a comment •

edited

Loading

matthewlane Mar 30, 2017 •

edited

Loading