Generate no-bid response for ech bid request not matched by a bid#1216
Merged
mkendall07 merged 2 commits intoprebid:masterfrom Jun 14, 2017
Merged
Conversation
Collaborator
|
There are now conflicts on this branch, @dmitriyshashkin please rebase onto master. |
…er_two_units_one_bid # Conflicts: # test/spec/adapters/prebidServer_spec.js
Collaborator
|
Thanks @dmitriyshashkin I've assigned @mkendall07 for a second review as he's been closer to the S2S work, this should merge Monday and be included in next release. |
mkendall07
approved these changes
Jun 14, 2017
Contributor
mkendall07
left a comment
mkendall07
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing!
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 6, 2017
….24.0 to aolgithub-master * commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits) Added changelog entry. Added records in aolPartnersIds.json. Prebid 0.25.0 Release Added Unruly adapter (prebid#1264) Fixing Adyoulike adapter for Safari iOS7 (prebid#1296) hide overflow to prevent scrolling (prebid#1294) fix protocol detection in iframe (prebid#1293) Add eplanning adapter (prebid#1245) Use Renderer command queue to render outstream (prebid#1283) Generate no-bid response for ech bid request not matched by a bid (prebid#1216) New Cox adapter (prebid#1228) Carambola Adapter (prebid#1221) Pass through transactionId and set fd=1 (prebid#1259) Integration test page for adapters (prebid#1182) Getting DigiTrustID in GumGum adapter (prebid#1256) Trion adapter (prebid#1254) use request bidder code as default bidderCode for createBid (prebid#1235) Add drop pixels once feature to AOL Adapter (prebid#1224) Rubicon Adapter - Adding 320x150 (prebid#1279) Prevent 'about:' protocol in _publisherTagUrl (prebid#1170) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #1215
My proposed solution is to go through all the bidders configured to work with prebid server, get all the requests associated with these bidders and generate a no-bid response for every request that can not be matched by id to a bid in prebid-server response.
This should cover lot's of cases simultaneously:
Other information
#1215