Add drop pixels once feature to AOL Adapter#1224
Conversation
|
Hey all, Just a note about this change: Is there a valid reason for any one SSP to drop pixels for every bid response (theirs or the DSPs) per a single page impression? Is this the kind of feature that could be added to the core of Prebid as opposed just being in adapters? |
|
@slimkrazy - PR #1229 adds a user sync module that will allow adapters to register pixels with the platform that will be dropped after the auction is done. At some point, all adapters will need to use this mechanism rather than directly adding the pixel. |
|
@vzhukovsky please have a look at #1229 to see if this will serve the purpose of this PR. The User Sync feature is slated for our next release. |
protonate
requested review from
grevory and
snapwich
and removed request for
snapwich
|
Hey @protonate - #1229 is missing iframe support, also it does not do what we require it to. #1229 is syncing after a hardcoded timeout, whereas we allow the publisher to decide if they want to alter the default behaviour of syncing on creative render to syncing on bid response. There is scope for us to use this utility for our default behaviour, but not for the case when a publisher actually wants to sync on bid response (they may want to attempt to improve match rates to increase returned CPMs). For us to adopt #1229, we'd need iframe support. Are we ok to have our changes approved as-is, then we can help to work on a generic solution that utilises the module in #1229 for a future release? |
|
Yes we are open to prioritizing a review of this PR to accommodate you while you wait for the official user sync module. I think we all expected user sync would be available by now. WRT to timeout, it is not hard-coded. There is a config option which will be documented. It will also increased by default with the enhancements we are working on. |
grevory
left a comment
grevory
left a comment
There was a problem hiding this comment.
Once we launch the user sync module with iframe support there is an expectation that this adapter will use that for firing pixels.
….24.0 to aolgithub-master * commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits) Added changelog entry. Added records in aolPartnersIds.json. Prebid 0.25.0 Release Added Unruly adapter (prebid#1264) Fixing Adyoulike adapter for Safari iOS7 (prebid#1296) hide overflow to prevent scrolling (prebid#1294) fix protocol detection in iframe (prebid#1293) Add eplanning adapter (prebid#1245) Use Renderer command queue to render outstream (prebid#1283) Generate no-bid response for ech bid request not matched by a bid (prebid#1216) New Cox adapter (prebid#1228) Carambola Adapter (prebid#1221) Pass through transactionId and set fd=1 (prebid#1259) Integration test page for adapters (prebid#1182) Getting DigiTrustID in GumGum adapter (prebid#1256) Trion adapter (prebid#1254) use request bidder code as default bidderCode for createBid (prebid#1235) Add drop pixels once feature to AOL Adapter (prebid#1224) Rubicon Adapter - Adding 320x150 (prebid#1279) Prevent 'about:' protocol in _publisherTagUrl (prebid#1170) ...
5 participants
Type of change
Description of change
Added drop pixels once feature + unit tests.
Fixed code style.