Update serverbid adapter to use smartsync#1324
Conversation
micha
force-pushed
the
serverbid-smartsync
branch
2 times, most recently
from
d568c33 to
5e85f82
Compare
harpere
left a comment
harpere
left a comment
There was a problem hiding this comment.
no tests for the new sync functionality, when window.SMARTSYNC evaluates to true?
src/adapters/serverbid.js
Outdated
There was a problem hiding this comment.
minor - as defined earlier on line 54, window[SMARTSYNC_CALLBACK] already redefines itself to an empty function, so doing it here again is redundant. So could just call window[SMARTSYNC_CALLBACK]();
There was a problem hiding this comment.
The reason for this setTimeout() call is to ensure that bids are fetched in the case that the callback (window[SMARTSYNC_CALLBACK]) is not called by the smartsync script in a timely manner. We also want to make sure that bids aren't fetched more than once. So consider the following cases:
- smartsync calls the callback promptly: this means that the timeout on line 63 has not yet fired, and we want to fetch bids and then set the callback to a no-op, so we don't fetch bids again when the timeout on line 63 fires.
- smartsync never calls the callback: this means that the timeout on line 63 will fire, fetch bids, and set the callback to a no-op.
- smartsync calls the callback after the timeout has fired: in this case we have already fetched bids and we don't want to fetch them again, so the callback must have already been set to a no-op. The code that would have done that is on line 65.
There was a problem hiding this comment.
Lines 64 and 65 handle the case where the callback is called after the timeout fires, so we don't fetch bids twice.
micha
force-pushed
the
serverbid-smartsync
branch
2 times, most recently
from
0304647 to
9148f00
Compare
|
Tests added! |
| } else { | ||
| window[SMARTSYNC_CALLBACK] = function() { | ||
| window[SMARTSYNC_CALLBACK] = function() {}; | ||
| _callBids(params); |
There was a problem hiding this comment.
@micha @harpere checking to make sure I understand this discussion from the previous PR #1301 (comment), what is the mechanism for publishers to opt in?
There was a problem hiding this comment.
Hi @matthewlane the publisher must set window.SMARTSYNC = true before bids are fetched.
micha
force-pushed
the
serverbid-smartsync
branch
from
cb53657 to
9148f00
Compare
|
@micha it looks like the travis build is failing because of the node version. Can you rebase your branch off master? |
jgrimes
force-pushed
the
serverbid-smartsync
branch
from
9148f00 to
8e5c29d
Compare
jgrimes
force-pushed
the
serverbid-smartsync
branch
from
8e5c29d to
84cca96
Compare
|
@mkendall07 I've rebased and fixed a linter issue (just an unused constant). Should be good to go! |
* tag '0.28.0' of https://github.com/prebid/Prebid.js: (27 commits) Prebid 0.28.0 Release Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563) add () for correct order of operations in scaling increments for currency (prebid#1559) AppnexusAst adapter update: Added source and version to request payload (prebid#1555) remove unnecessary spread operator (prebid#1561) Adxcg adapter (prebid#1554) Upgrade sinon to 3.x (prebid#1491) Rename vastPayload to vastXml (prebid#1556) Single-size sizes array now can be taken, too (prebid#1535) Updated the istanbul-instrumenter-loader (prebid#1550) Add AerServ Adapter (prebid#1538) Fixed imports and made adform support aliasing (prebid#1518) Custom granularity fix (prebid#1546) Fix `documentation lint` issues (prebid#1544) Yieldbot adunit bidder params slot name usage fix (prebid#1394) Update serverbid adapter to use smartsync (prebid#1324) Add improvedigitalBidAdapter (prebid#1381) Fix prebid#1533 spring server typo (prebid#1542) userSync is off by default (prebid#1543) currency module (prebid#1374) ...
….28.0 to aolgithub-master * commit '4d9ade3df767750743f8888ed9efd6c77f8d0050': (26 commits) Added changelog entry. Added new aol partners ids. Prebid 0.28.0 Release Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563) add () for correct order of operations in scaling increments for currency (prebid#1559) AppnexusAst adapter update: Added source and version to request payload (prebid#1555) remove unnecessary spread operator (prebid#1561) Adxcg adapter (prebid#1554) Upgrade sinon to 3.x (prebid#1491) Rename vastPayload to vastXml (prebid#1556) Single-size sizes array now can be taken, too (prebid#1535) Updated the istanbul-instrumenter-loader (prebid#1550) Add AerServ Adapter (prebid#1538) Fixed imports and made adform support aliasing (prebid#1518) Custom granularity fix (prebid#1546) Fix `documentation lint` issues (prebid#1544) Yieldbot adunit bidder params slot name usage fix (prebid#1394) Update serverbid adapter to use smartsync (prebid#1324) Add improvedigitalBidAdapter (prebid#1381) Fix prebid#1533 spring server typo (prebid#1542) ...
6 participants
Type of change
Description of change
Adds the option to sync cookies with RTB partners (see also #1301).