Conversation
matthewlane
approved these changes
Sep 5, 2017
jaiminpanchal27
approved these changes
Sep 5, 2017
jaiminpanchal27
added a commit
that referenced
this pull request
Sep 5, 2017
This reverts commit dc4736a.
1 task
jaiminpanchal27
added a commit
that referenced
this pull request
Sep 5, 2017
philipwatson
pushed a commit
to mbrtargeting/Prebid.js
that referenced
this pull request
Sep 18, 2017
* Removed deprecated calls. * Replaced some .value() calls with .returns() ones * Fixed all the remaining tests... except for one which was broken. * Updated the yarn lockfile. * Updated to sinon 3.x * Removed the imports-loader, which I didnt actually need. * Commented out another broken test. * Fixed a bunch of errors which were pulled in during the merge. * Better comments on why certain tests were removed.
philipwatson
pushed a commit
to mbrtargeting/Prebid.js
that referenced
this pull request
Sep 18, 2017
This reverts commit dc4736a.
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Sep 18, 2017
* tag '0.28.0' of https://github.com/prebid/Prebid.js: (27 commits) Prebid 0.28.0 Release Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563) add () for correct order of operations in scaling increments for currency (prebid#1559) AppnexusAst adapter update: Added source and version to request payload (prebid#1555) remove unnecessary spread operator (prebid#1561) Adxcg adapter (prebid#1554) Upgrade sinon to 3.x (prebid#1491) Rename vastPayload to vastXml (prebid#1556) Single-size sizes array now can be taken, too (prebid#1535) Updated the istanbul-instrumenter-loader (prebid#1550) Add AerServ Adapter (prebid#1538) Fixed imports and made adform support aliasing (prebid#1518) Custom granularity fix (prebid#1546) Fix `documentation lint` issues (prebid#1544) Yieldbot adunit bidder params slot name usage fix (prebid#1394) Update serverbid adapter to use smartsync (prebid#1324) Add improvedigitalBidAdapter (prebid#1381) Fix prebid#1533 spring server typo (prebid#1542) userSync is off by default (prebid#1543) currency module (prebid#1374) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Oct 12, 2017
….28.0 to aolgithub-master * commit '4d9ade3df767750743f8888ed9efd6c77f8d0050': (26 commits) Added changelog entry. Added new aol partners ids. Prebid 0.28.0 Release Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563) add () for correct order of operations in scaling increments for currency (prebid#1559) AppnexusAst adapter update: Added source and version to request payload (prebid#1555) remove unnecessary spread operator (prebid#1561) Adxcg adapter (prebid#1554) Upgrade sinon to 3.x (prebid#1491) Rename vastPayload to vastXml (prebid#1556) Single-size sizes array now can be taken, too (prebid#1535) Updated the istanbul-instrumenter-loader (prebid#1550) Add AerServ Adapter (prebid#1538) Fixed imports and made adform support aliasing (prebid#1518) Custom granularity fix (prebid#1546) Fix `documentation lint` issues (prebid#1544) Yieldbot adunit bidder params slot name usage fix (prebid#1394) Update serverbid adapter to use smartsync (prebid#1324) Add improvedigitalBidAdapter (prebid#1381) Fix prebid#1533 spring server typo (prebid#1542) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Dependency upgrade
Description of change
Upgrading sinon to the latest version. Updating lots of tests to use the newer APIs.
Also includes some code to make proper mocks within an individual test easier. The update exposed some tests which weren't doing it properly.
Other information
This was a precondition for even investigating the root issue that @mkendall07 ran into in #1427. I had to fiddle with tje webpack build... but sinon 1.x doesn't export itself properly.
According to this guy, they fixed the issue in sinon 2.x.
I updated all the way to 3.x because "why not?" It didn't require any extra code changes on our end.
Sadly it looks like fixing the issue from #1427 will take lots of other changes too (logged as #1508)... but since I already had to do this work to upgrade, I figured I may as well commit it.