Mention NodeJS 4.0 dependency in the README#1386
Conversation
This caused me some trouble on a Debian Jessie machine (which ships with NodeJS 0.10).
|
Thanks for the PR. This probably happened during #1355, where I definitely overlooked node compatibility. Could you also add an |
|
Of course! Didn't know that option existed, thanks! |
dbemiller
left a comment
dbemiller
left a comment
There was a problem hiding this comment.
I just found out about it myself a few weeks ago. Very helpful, though.
Thanks a bunch!
|
There is actually a mention of node 4.0 here already at the bottom of this portion: https://github.com/prebid/Prebid.js/blob/master/README.md#Build |
|
Ah, missed that one. I moved and changed the note. 'npm install' aborts with a lot of errors on NodeJS < 4.0, it's not just needed for 'gulp' |
|
thanks! |
…built * 'master' of https://github.com/prebid/Prebid.js: (95 commits) Specify --browsers when using gulp test --watch (prebid#1420) Added aliases for aol adapter. (prebid#1371) Added MobFox Adapter (prebid#1312) Fixed style error. (prebid#1419) Add native support for Criteo adapter (prebid#999) Update admediaBidAdapter.js (prebid#1395) Increment pre version (prebid#1413) Prebid 0.26.1 Release (prebid#1412) fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411) Lint modules directory (prebid#1404) Set outstream mediaType based on renderer in response (prebid#1391) Fixing the BidAdjustmentEvent fire time (prebid#1399) Fix banner showing up in prebid-core.js (prebid#1388) Mention NodeJS 4.0 dependency in the README (prebid#1386) Increment pre version (prebid#1385) Prebid 0.26.0 Release (prebid#1384) PulsePoint Lite adapter - adding createNew method for aliasing. (prebid#1383) Modernizing build dependencies (prebid#1355) StickyAdsTV bidder adapter update (prebid#1311) Added CPM value as parameter for Vertoz Adapter (prebid#1306) ...
3 participants
This caused me some trouble on a Debian Jessie machine (which ships with NodeJS 0.10).