Skip to content

Update JSDoc to call the module pbjs#1572

Merged
mkendall07 merged 4 commits intomasterfrom
docs-call-the-module-pbjs
Oct 19, 2017
Merged

Update JSDoc to call the module pbjs#1572
mkendall07 merged 4 commits intomasterfrom
docs-call-the-module-pbjs

Conversation

@rmloveland
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

This change renames all uses of $$PREBID_GLOBAL$$ in the JSDoc of src/prebid.js to pbjs.

(instead of `$$PREBID_GLOBAL$$``)
Copy link
Contributor

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although would be great if you could add @alias for some functions that don't have it. For example:

$$PREBID_GLOBAL$$.setTargetingForAst = function() {

$$PREBID_GLOBAL$$.onEvent = function (event, handler, id) {

@rmloveland
Copy link
Contributor Author

@mkendall07 cool - I added @alias to everything that appeared to be hanging off the pbjs object (that didn't already have an alias tag). LMK what you think!

@protonate
Copy link
Collaborator

@rmloveland this has conflicts now, please rebase onto master and resolve.

@mkendall07
Copy link
Contributor

@rmloveland sorry this took so long for me to re-review. I resolved conflicts so hopefully this is good to go.

@mkendall07 mkendall07 merged commit b721d6f into master Oct 19, 2017
@mkendall07 mkendall07 deleted the docs-call-the-module-pbjs branch October 19, 2017 21:05
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Oct 25, 2017
* 'master' of https://github.com/prebid/Prebid.js: (414 commits)
  Make response headers available to the specs (prebid#1748)
  add option to run tests in a specific file (prebid#1727)
  Update JCM Adapter to 1.0  (prebid#1715)
  Finished an unfinished comment. (prebid#1749)
  Platform.io Bidder Adapter update.  Prebid v1.0. (prebid#1705)
  Fix window.top.host cross origin issue when in nested iframes. (prebid#1730)
  fix log message not displaying when referencing missing bidder (prebid#1737)
  Allow more than one placement from one page (prebid#1692)
  Justpremium Adapter bugfix (prebid#1716)
  Updating license (prebid#1717)
  realvuBidAdapter  (prebid#1571)
  Update JSDoc to call the module `pbjs` (prebid#1572)
  Update Beachfront adapter for v1.0 (prebid#1675)
  Update AdButler adapter for Prebid v1.0 (prebid#1664)
  Increment pre version
  Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645)
  Prebid 0.31.0 Release
  Support native click tracking (prebid#1691)
  Initial commit for video support for pbs (prebid#1706)
  Fixes: Immediate adapter response may end auction (prebid#1690)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments