Update JCM Adapter to 1.0 #1715
Conversation
Test for jcm adapter
dbemiller
left a comment
dbemiller
left a comment
There was a problem hiding this comment.
The code looks pretty good, barring a few things.
I'm not getting bids back, though. Screenshot to follow.
adapters.json
Outdated
| @@ -0,0 +1,34 @@ | |||
| [ | |||
There was a problem hiding this comment.
File committed accidentally?
package.json
Outdated
| "type": "git", | ||
| "url": "https://github.com/prebid/Prebid.js.git" | ||
| }, | ||
|
|
There was a problem hiding this comment.
More unintended changes?
There was a problem hiding this comment.
There should be no changes to package.json or adapters.json in this PR.
There was a problem hiding this comment.
ok. Please remove them when you update, then
| expect(bidObj).to.have.property('callbackId').and.to.equal('3c9408cdbf2f68'); | ||
| it('sends bid request to ENDPOINT via GET', () => { | ||
| const request = spec.buildRequests(bidRequests); | ||
| expect(request.method).to.equal('GET'); |
There was a problem hiding this comment.
Needs some real assertions... barely tests buildRequests at all.
There was a problem hiding this comment.
Will look into this.
|
|
|
Our servers required an update. The test ad request should now deliver an ad. |
|
nope... still getting the same error |
|
Please retest the ad request. The cross-origin issue is resolved. |
* 'master' of https://github.com/prebid/Prebid.js: (414 commits) Make response headers available to the specs (prebid#1748) add option to run tests in a specific file (prebid#1727) Update JCM Adapter to 1.0 (prebid#1715) Finished an unfinished comment. (prebid#1749) Platform.io Bidder Adapter update. Prebid v1.0. (prebid#1705) Fix window.top.host cross origin issue when in nested iframes. (prebid#1730) fix log message not displaying when referencing missing bidder (prebid#1737) Allow more than one placement from one page (prebid#1692) Justpremium Adapter bugfix (prebid#1716) Updating license (prebid#1717) realvuBidAdapter (prebid#1571) Update JSDoc to call the module `pbjs` (prebid#1572) Update Beachfront adapter for v1.0 (prebid#1675) Update AdButler adapter for Prebid v1.0 (prebid#1664) Increment pre version Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) ...
4 participants
Type of change
-- [ ] Other
Description of change
Update JCM adapter for 1.0 compatability