Update spotx video adapter to set the spotx_ad_key used in DFP#1614
Merged
mkendall07 merged 2 commits intoprebid:masterfrom Oct 13, 2017
npeceniak:spotx-adapter-ad_id-update
Merged
Update spotx video adapter to set the spotx_ad_key used in DFP#1614mkendall07 merged 2 commits intoprebid:masterfrom npeceniak:spotx-adapter-ad_id-update
mkendall07 merged 2 commits intoprebid:masterfrom
npeceniak:spotx-adapter-ad_id-update
Conversation
targeting to the bid.adId
mkendall07
suggested changes
Sep 28, 2017
modules/spotxBidAdapter.js
Outdated
| bid.cpm = KVP_Object.spotx_bid; | ||
| bid.vastUrl = url; | ||
| bid.ad = url; | ||
| bid.adId = KVP_Object.spotx_ad_key; |
Contributor
There was a problem hiding this comment.
This will break some internals in prebid.js unfortunately. Can you set the key using this method:
https://github.com/prebid/Prebid.js/blob/master/modules/xhbBidAdapter.js#L23
Basically set another property on bid and retrieve it using that function.
The only downside of overriding this key is you can't reference the bid later using this key but I assume that's ok.
Contributor
|
@npeceniak needs a little work for merge. |
…ting - Instead of setting the adid to the spotx key in the bid response itself we now set a key bid.spotx_ad_key on the bid and then overwrite the hb_adid using this key.
Contributor
Author
|
@mkendall07 Sorry for the delay in getting this updated. The adapter should be setting hb_adid the correct way now. |
mkendall07
approved these changes
Oct 13, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Oct 18, 2017
* tag '0.31.0' of https://github.com/prebid/Prebid.js: (54 commits) Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) Rubicon feature/s2s test module (prebid#1678) Renaming of "huddledmasses" adapter into colossusssp (prebid#1701) Don't set non-object configurations (prebid#1704) Update JSDoc for `pbjs.enableAnalytics` (prebid#1565) Add ad units event (prebid#1702) AppnexusAst adapter: logging error message from endpoint (prebid#1697) AppnexusAst bidadapter markdown file (prebid#1696) Change Default Content-Type for POST Requests to 'application/json' (prebid#1681) Code improvement for trustx adapter (prebid#1673) PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686) Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614) Fix broken AOL mobile endpoint secure bid requests (prebid#1684) Fix adapter tests that hardcoded pbjs. (prebid#1666) no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676) remove bidmanager from rubicon tests (prebid#1671) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Oct 30, 2017
….31.0 to aolgithub-master * commit 'e7341c948014a789084849495171d08d4b353d07': (21 commits) Added changelog entry. Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) Rubicon feature/s2s test module (prebid#1678) Renaming of "huddledmasses" adapter into colossusssp (prebid#1701) Don't set non-object configurations (prebid#1704) Update JSDoc for `pbjs.enableAnalytics` (prebid#1565) Add ad units event (prebid#1702) AppnexusAst adapter: logging error message from endpoint (prebid#1697) AppnexusAst bidadapter markdown file (prebid#1696) Change Default Content-Type for POST Requests to 'application/json' (prebid#1681) Code improvement for trustx adapter (prebid#1673) PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686) Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614) Fix broken AOL mobile endpoint secure bid requests (prebid#1684) Fix adapter tests that hardcoded pbjs. (prebid#1666) no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
In order for DFP targeting to work correctly we need access to the cpm and spotx_ad_key. We were already passing the cpm value but with this update we are now setting the spotx_ad_key to the bid.adId key so that it can be included with the prebid standard targeting keys.
Be sure to test the integration with your adserver using the Hello World sample page.
Other information