remove bidmanager from rubicon tests#1671
Conversation
|
|
||
| sandbox.stub(spec, 'buildRequests'); | ||
|
|
||
| rubiconAdapter.callBids(sizesBidderRequest); |
There was a problem hiding this comment.
This test can be easily tested by using spec.isBidRequestValid and spec.buildRequests. Call to callBids can be removed.
Same goes for other tests in for request test suite. They can be tested using spec functions.
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
There was a problem hiding this comment.
Also, Is this tested against prebid-1.0 branch ?
|
Updated. Also tested against 1.0 branch and everything passed there as well. |
|
|
||
| describe('callBids implementation', () => { | ||
| describe('buildRequests implementation', () => { | ||
| let rubiconAdapter; |
There was a problem hiding this comment.
I think you can get rid of the rubiconAdapter here, since your tests work on the spec
| @@ -1005,7 +816,6 @@ describe('the rubicon adapter', () => { | |||
| beforeEach(() => { | |||
| // monitor userSync registrations | |||
| userSyncStub = sandbox.stub(userSync, 'registerSync'); | |||
There was a problem hiding this comment.
Are you relying on this stub? If you're just testing the response of getUserSyncs, I don't think you should have to.
| @@ -128,43 +127,6 @@ describe('the rubicon adapter', () => { | |||
| sandbox.restore(); | |||
There was a problem hiding this comment.
sandbox probably shouldn't need to useFakeServer anymore. Also it looks like the adUnit (a few dozen lines above this comment, so github won't let me put a comment there) is unused now.
* tag '0.31.0' of https://github.com/prebid/Prebid.js: (54 commits) Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) Rubicon feature/s2s test module (prebid#1678) Renaming of "huddledmasses" adapter into colossusssp (prebid#1701) Don't set non-object configurations (prebid#1704) Update JSDoc for `pbjs.enableAnalytics` (prebid#1565) Add ad units event (prebid#1702) AppnexusAst adapter: logging error message from endpoint (prebid#1697) AppnexusAst bidadapter markdown file (prebid#1696) Change Default Content-Type for POST Requests to 'application/json' (prebid#1681) Code improvement for trustx adapter (prebid#1673) PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686) Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614) Fix broken AOL mobile endpoint secure bid requests (prebid#1684) Fix adapter tests that hardcoded pbjs. (prebid#1666) no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676) remove bidmanager from rubicon tests (prebid#1671) ...
4 participants
Type of change
Description of change
Removing all references of the bidManager from the rubicon tests to be 1.0 compatible.