Support aspect ratio specification for native images#1634
Merged
jaiminpanchal27 merged 1 commit intomasterfrom Oct 3, 2017
Merged
Support aspect ratio specification for native images#1634jaiminpanchal27 merged 1 commit intomasterfrom
jaiminpanchal27 merged 1 commit intomasterfrom
Conversation
matthewlane
force-pushed
the
native-aspect-ratio
branch
2 times, most recently
from
c368889 to
be9940d
Compare
matthewlane
force-pushed
the
native-aspect-ratio
branch
from
be9940d to
e539c68
Compare
mkendall07
approved these changes
Oct 3, 2017
| minimumParams: { sizes: [{}] }, | ||
| }, | ||
| sponsoredBy: 'sponsored_by' | ||
| sponsoredBy: 'sponsored_by', |
Contributor
There was a problem hiding this comment.
are trailing commas allowed now?? 👍
Collaborator
Author
There was a problem hiding this comment.
jaiminpanchal27
approved these changes
Oct 3, 2017
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Oct 25, 2017
….30.0 to aolgithub-master * commit '5a8d2bf93ee15071a78e24ac976103cacf3c6021': (35 commits) Added changelog entry. Prebid 0.30.1 Release Remove undefined variable usage (prebid#1662) fixes bug for IE when invalid value passed to parse (prebid#1657) Aliasbidder fix (prebid#1652) prebidAdapter secure support (prebid#1655) Increment pre version Prebid 0.30.0 Release Add native param support to mediaTypes (prebid#1625) PulsePoint Lite adpater changes (prebid#1630) Appnexus ast unittest updates (prebid#1654) Support aspect ratio specification for native images (prebid#1634) Revert changes for switch between client side and server side. (prebid#1653) rubicon converted to bidderFactory (prebid#1624) Add JSDoc for `pbjs.getAllWinningBids` (prebid#1566) Add ignore-loader to handle .md files (prebid#1646) fixed PBS cookie syncs (prebid#1637) Add placementId request param to Yieldmo bid adapter (prebid#1632) Adxcg analytics adapter (prebid#1599) Add publisher sub-id support to the Criteo adapter (prebid#1629) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This change refactors the native mapping portion of appnexusAst adapter to allow specifying aspect ratios for native image and icon assets. Aspect ratios are defined within a native image parameter with the keyword
aspect_ratios, and aratio_widthandratio_height.min_widthmay optionally be given. Example: