Conversation
|
@bretg |
|
@mkendall07 - good to know it's at least partly covered. That certainly lowers the priority, but might still be a useful lever -- depends on the referrer that PBS receives. There are are two scenarios where the secure flag needs to be passed:
if the referrer is overridden to the page level (as it should be), then PBS doesn't know whether it's in scenario 2. |
mkendall07
left a comment
mkendall07
left a comment
There was a problem hiding this comment.
Needs update to prebid.js
| tid: bidRequest.tid, | ||
| max_bids: config.maxBids, | ||
| timeout_millis: config.timeout, | ||
| secure: config.secure, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually I think the current PR is what we want -- if it's added to the object.assign in prebid.js as a default, then Prebid Server's URL check is always bypassed. The behavior of the code here is that when the s2sConfig contains a secure override, it's sent, otherwise PBS detects.
Doc update for prebid/Prebid.js#1655
….30.0 to aolgithub-master * commit '5a8d2bf93ee15071a78e24ac976103cacf3c6021': (35 commits) Added changelog entry. Prebid 0.30.1 Release Remove undefined variable usage (prebid#1662) fixes bug for IE when invalid value passed to parse (prebid#1657) Aliasbidder fix (prebid#1652) prebidAdapter secure support (prebid#1655) Increment pre version Prebid 0.30.0 Release Add native param support to mediaTypes (prebid#1625) PulsePoint Lite adpater changes (prebid#1630) Appnexus ast unittest updates (prebid#1654) Support aspect ratio specification for native images (prebid#1634) Revert changes for switch between client side and server side. (prebid#1653) rubicon converted to bidderFactory (prebid#1624) Add JSDoc for `pbjs.getAllWinningBids` (prebid#1566) Add ignore-loader to handle .md files (prebid#1646) fixed PBS cookie syncs (prebid#1637) Add placementId request param to Yieldmo bid adapter (prebid#1632) Adxcg analytics adapter (prebid#1599) Add publisher sub-id support to the Criteo adapter (prebid#1629) ...
2 participants
Type of change
Description of change
Passing the 'secure' flag from s2sConfig through to Prebid Server
Other information
Could use a better unit test -- but that stands true of this module already... looks like there's not a good suite of checks that s2sConfig values are sent through to server. e.g. accountId, timeout_millis.