Adding 33Across adapter#1805
Merged
jaiminpanchal27 merged 2 commits intoprebid:masterfrom Nov 9, 2017
Merged
Conversation
jaiminpanchal27
requested changes
Nov 8, 2017
Collaborator
jaiminpanchal27
left a comment
There was a problem hiding this comment.
@curlyblueeagle Awesome code.
Minor change needed.
Thanks
| siteId: SITE_ID, | ||
| productId: PRODUCT_ID | ||
| }, | ||
| placementCode: 'div-id', |
Collaborator
There was a problem hiding this comment.
In 1.0 we are going to rename placementCode to adUnitCode. Please update
Contributor
Author
|
@jaiminpanchal27 Thanks. I have made the changes requested. Not sure why my update breaks the test for another adapter. Please let me know if you need anything from me. |
jaiminpanchal27
approved these changes
Nov 8, 2017
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Dec 28, 2017
….33.0 to aolgithub-master * commit '3e9756098bb20ecbe0314f16eed5298c5675b24c': (32 commits) Wrapped content type in options object. Added partners ids. Added changelog entry. Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) PubMatic adapter (prebid#1707) Added sizes to Rubicon Adapter (prebid#1818) jsonpFunction name should match the namespace (prebid#1785) Adding 33Across adapter (prebid#1805) Unit test fix (prebid#1812) ...
matthewlane
pushed a commit
that referenced
this pull request
Feb 6, 2018
* Adding 33across adapter * Updated per code review from Prebid. See #1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in #1855 to fix usage of deprecated method
matthewlane
pushed a commit
that referenced
this pull request
Mar 6, 2018
* Adding 33across adapter * Updated per code review from Prebid. See #1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in #1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option
jaiminpanchal27
pushed a commit
that referenced
this pull request
Apr 12, 2018
* Adding 33across adapter * Updated per code review from Prebid. See #1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in #1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies
jsnellbaker
pushed a commit
that referenced
this pull request
Jul 26, 2018
* Adding 33across adapter * Updated per code review from Prebid. See #1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in #1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add new bidder adapter for 33Across
In order to receive bids please map localhost to (any) test domain. Also update prebid config section as follows:
Be sure to test the integration with your adserver using the Hello World sample page.
aparna.hegde@33across.comOther information