Update AOL adapter for v1.0 by vzhukovsky · Pull Request #1693 · prebid/Prebid.js

vzhukovsky · 2017-10-16T08:06:16Z

Type of change

Other

Description of change

AOL adapter changes for Prebid 1.0.

vzhukovsky · 2017-10-16T09:41:42Z

Hi everyone.

I reviewed new adapter requirements and found only one collision with this PR. It is related to user syncs. In 0.X.X our adapter has following features:

Mode for dropping pixels (user syncs) during ad rendering (the default behaviour);
Mode for dropping pixels right after getting bid response back;
Also we drop pixels only once for both mentioned modes;

In this PR 2# and 3# are implemented via new Prebid userSyncs module. But I do not see any legal way to implement 1# because it requires globals and some changes in core modules.

We would really like to keep all these features in 1.0. Let's discuss a way to do it.

vzhukovsky · 2017-10-19T10:15:56Z

@mjacobsonny @jaiminpanchal27 @ndhimehta Hi everyone.
Is there any chance to review the changes?

snapwich · 2017-10-25T16:04:53Z

test/spec/modules/aolBidAdapter_spec.js

@@ -2,6 +2,8 @@ import {expect} from 'chai';
 import * as utils from 'src/utils';
 import AolAdapter from 'modules/aolBidAdapter';
 import bidmanager from 'src/bidmanager';


You will need to remove any references to the bidmanager as it is no longer present in 1.0. You can see how I did this for the rubicon adapter here: https://github.com/prebid/Prebid.js/pull/1671/files

Also, all references to callBids should be removed as well since that API has changed. Tests should be refactored to test against the spec directly, rather than the adapter interface. The adapter interface is tested in the bidderFactory spec.

snapwich · 2017-10-25T16:25:19Z

src/adapters/bidderFactory.js

      // register any required usersync pixels.
      const responses = [];
-      function afterAllResponses() {
+      function afterAllResponses(request) {


This is not going to work correctly. afterAllResponses is fired once and you are passing in a singular request, which means if there are multiple requests, afterAllResponses is only going to get the last one.

snapwich · 2017-10-25T16:27:49Z

modules/aolBidAdapter.js

-      } else if (isMarketplaceRequest) {
-        apiUrl = _buildMarketplaceUrl(bid);
-      }
+    if (bidResponse && bidRequest && bidRequest.userSyncOn === constants.EVENTS.BID_RESPONSE) {


if you are using the bidRequest just to get at bid.params, perhaps you could use setConfig and getConfig instead in the config module?

It'd probably be best to use the userSync API to check if user syncs should fire. The config is passed as the first paramteter to getUserSyncs and can be used like this: https://github.com/prebid/Prebid.js/blob/master/modules/appnexusAstBidAdapter.js#L115

Yes, we use it just for fetching the param.

It looks like we can create new namespace via new setConfig API and define it here.
setConfig({aol: { userSyncOn: 'bidResponse'}}});

Yes you could. Is there a reason you want to do your own user sync flag as opposed to the general

pbjs.setConfig({ userSync: { iframeEnabled: true }});

and checking the syncConfig that's passed into getUserSyncs?

snapwich · 2017-10-25T16:36:39Z

src/adapters/bidderFactory.js

                method: 'POST',
-                contentType: 'text/plain',
+                contentType: request.contentType || 'text/plain',
+                customHeaders: request.customHeaders || {},


The ability to specify the contentType and customHeaders was already added here as request.options

…ol-adapter-for-1.0 # Conflicts: # src/adapters/bidderFactory.js

jaiminpanchal27

@vzhukovsky Left some comments.
I am not able to validate bids by testing on hello_world

jaiminpanchal27 · 2017-11-03T15:07:46Z

modules/aolBidAdapter.js

-            );
-          }
-          showCpmAdjustmentWarning = false; // warning is shown at most once
+  bidRequest.bidderCode = bid.bidder;


Any reason to add these param to bidRequest. I don't see its use.

Hi. Thanks for reviewing it.

We have an analytic adapter that is not part of Prebid official yet. Having "bidderCode" here allows us to break out the reporting between different aliases.

jaiminpanchal27 · 2017-11-03T15:11:00Z

modules/aolBidAdapter.js

-            _addErrorBidResponse(bid, response);
-            return;
-          }
+function interpretResponse(bidResponse, bidRequest) {


#1748 changed the first argument of interpretResponse to:

body: responseBody, headers: { get: function(header) { /* returns a header from the HTTP response */ } } }```

jaiminpanchal27 · 2017-11-03T15:12:13Z

modules/aolBidAdapter.js

-    return bidder === AOL_BIDDERS_CODES.aol || bidder === AOL_BIDDERS_CODES.onedisplay;
-  }
+  return {
+    bidderCode: bid.bidderCode,


Some bidResponse params are missing and invalid. Please check http://prebid.org/dev-docs/bidder-adapter-1.html

vzhukovsky · 2017-11-08T20:20:23Z

Please use the following setting for validating bids:
{bidder: 'aol', params: { placement: 3611253, network: '9599.1' }}

vzhukovsky · 2017-11-13T07:17:56Z

@jaiminpanchal27 Hi. Comments are fixed and now you can validate the bids.

jaiminpanchal27 · 2017-11-13T15:25:21Z

@vzhukovsky You missed adding required param ttl. I was able to validate bids by adding that param. Please update accordingly.

Also can you update .md file with these new params for anyone to test.

vzhukovsky · 2017-11-14T14:41:54Z

@jaiminpanchal27 Hi. Thank you for reviewing it. I added ttl param and improved .md file.

mkendall07 · 2017-11-14T19:33:22Z

modules/aolBidAdapter.js

-    return bidder === AOL_BIDDERS_CODES.aol || bidder === AOL_BIDDERS_CODES.onedisplay;
-  }
+  return {
+    bidderCode: bidRequest.bidderCode,


Edit: nevermind!

* unstream/master: (36 commits) + Add Optimatic Bid Adapter (prebid#1837) Add Bridgewell adapter (prebid#1825) Kumma adapter updated for Prebid 1.0 (prebid#1766) Touchup add bid response (prebid#1822) Fix skipped test (prebid#1836) Added new size in Rubicon pbjs Adapter (prebid#1842) HuddledMasses header bidding adapter (prebid#1806) Increment pre version Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) ...

Looks like the Prebid.js PR updating AOL for 1.0 is here: prebid/Prebid.js#1693

….33.0 to aolgithub-master * commit '3e9756098bb20ecbe0314f16eed5298c5675b24c': (32 commits) Wrapped content type in options object. Added partners ids. Added changelog entry. Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) PubMatic adapter (prebid#1707) Added sizes to Rubicon Adapter (prebid#1818) jsonpFunction name should match the namespace (prebid#1785) Adding 33Across adapter (prebid#1805) Unit test fix (prebid#1812) ...

Converted AOL bid adapter to Prebid 1.0.

1023e16

Added description file for AOL Adapter.

7cc2754

vzhukovsky force-pushed the contrib/aol-adapter-for-1.0 branch from a49630d to 7cc2754 Compare October 16, 2017 10:47

mjacobsonny added the Prebid 1.0 label Oct 16, 2017

jaiminpanchal27 assigned ndhimehta Oct 16, 2017

bretg requested a review from snapwich October 19, 2017 14:24

jaiminpanchal27 assigned snapwich and unassigned ndhimehta Oct 19, 2017

snapwich requested changes Oct 25, 2017

View reviewed changes

ndhimehta added the ready label Oct 25, 2017

matthewlane added needs update and removed ready labels Oct 31, 2017

vzhukovsky added 9 commits November 1, 2017 13:36

Merge remote-tracking branch 'remotes/upstream/master' into contrib/a…

747ff18

…ol-adapter-for-1.0 # Conflicts: # src/adapters/bidderFactory.js

Move one mobile post properties to options object.

dd224a6

Implemented AOL user syncs config via setConfig API.

861c335

Refactored Marketplace tests for Prebid 1.0.

214faba

Refactored One Mobile tests for Prebid 1.0.

cdd65b9

Fixed faining tests for One Mobile endpoint.

6c9c85d

Refactored get userSyncs tests for Prebid 1.0.

f2d4942

Refactored interpretResponse tests for Prebid 1.0.

2f9c39a

Remove outdated tests.

1524b2b

ndhimehta added the ready label Nov 1, 2017

ndhimehta assigned jaiminpanchal27 and unassigned snapwich Nov 1, 2017

jaiminpanchal27 requested changes Nov 3, 2017

View reviewed changes

jaiminpanchal27 added not receiving bids and removed ready labels Nov 3, 2017

Fixed review comments.

85c80a3

vzhukovsky added 2 commits November 14, 2017 16:44

Added ttl support for AOL adapter.

a1d0688

Improved aol adapter docs.

265079b

jaiminpanchal27 approved these changes Nov 14, 2017

View reviewed changes

jaiminpanchal27 added LGTM and removed needs update not receiving bids labels Nov 14, 2017

mkendall07 reviewed Nov 14, 2017

View reviewed changes

mkendall07 approved these changes Nov 14, 2017

View reviewed changes

mkendall07 merged commit 81a3f5f into prebid:master Nov 14, 2017

rmloveland pushed a commit to prebid/prebid.github.io that referenced this pull request Dec 20, 2017

Update AOL adapter doc to note 1.0 support

bb8617c

Looks like the Prebid.js PR updating AOL for 1.0 is here: prebid/Prebid.js#1693

vzhukovsky deleted the contrib/aol-adapter-for-1.0 branch February 8, 2018 14:57

vzhukovsky mentioned this pull request Jul 16, 2018

AOL adapter - dropping pixels when creatives in safe frames. #2816

Closed

1 task

Conversation

vzhukovsky commented Oct 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Uh oh!

vzhukovsky commented Oct 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vzhukovsky commented Oct 19, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vzhukovsky Oct 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snapwich Oct 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vzhukovsky Nov 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vzhukovsky commented Nov 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vzhukovsky commented Nov 13, 2017

Uh oh!

jaiminpanchal27 commented Nov 13, 2017

Uh oh!

vzhukovsky commented Nov 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkendall07 Nov 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

vzhukovsky commented Oct 16, 2017 •

edited

Loading

vzhukovsky commented Oct 16, 2017 •

edited

Loading

vzhukovsky Oct 26, 2017 •

edited

Loading

snapwich Oct 27, 2017 •

edited

Loading

vzhukovsky Nov 8, 2017 •

edited

Loading

vzhukovsky commented Nov 8, 2017 •

edited

Loading

vzhukovsky commented Nov 14, 2017 •

edited

Loading

mkendall07 Nov 14, 2017 •

edited

Loading