Prebid.js 1.0 support for Kumma adapter#1766
Prebid.js 1.0 support for Kumma adapter#1766matthewlane merged 3 commits intoprebid:masterfrom yehonatanshac:master
Conversation
There was a problem hiding this comment.
The code in general looks great, but... I'm not getting any bids back from your server when using the params in your .md. It looks like the server is sending empty responses.
If there are any special notes needed to get back a test bid (e.g. "emulate a mobile device" or "make sure localhost isn't in your URL"), please add them to the .md. Otherwise, if it's a server bug, let me know when it's fixed so I can test again.
modules/kummaBidAdapter.js
Outdated
| function bidResponseAvailable(bidRequest, bidResponse) { | ||
| const idToImpMap = {}; | ||
| const idToBidMap = {}; | ||
| const ortbRequest = parse(bidRequest.data); |
There was a problem hiding this comment.
You can simplify this quite a bit by just throwing the error here. The bidderFactory runs interpretResponse in a try/catch, and does a logError if anything goes wrong.
Also... your parse function just returns null on error, which will make openrtbRequest.imp throw an error anyway.
modules/kummaBidAdapter.js
Outdated
| } | ||
| return null; | ||
| } | ||
| function referrer() { |
There was a problem hiding this comment.
This can be replaced by getTopWindowReferrer() in utils.
|
I changed the md file. Now it should work. |
* unstream/master: (36 commits) + Add Optimatic Bid Adapter (prebid#1837) Add Bridgewell adapter (prebid#1825) Kumma adapter updated for Prebid 1.0 (prebid#1766) Touchup add bid response (prebid#1822) Fix skipped test (prebid#1836) Added new size in Rubicon pbjs Adapter (prebid#1842) HuddledMasses header bidding adapter (prebid#1806) Increment pre version Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) ...
5 participants
Type of change
Description of change
prebid.js 1.0 support for Kumma adapter
test parameters for validating bids
bidder: 'kumma',
params: {
pubId: '28082',
siteId: '26047',
placementId: '123',
size: '250X250'
}
contact email of the adapter’s maintainer yehonatan@kumma.com
[X ] official adapter submission