HuddledMasses header bidding adapter by HuddledMasses · Pull Request #1806 · prebid/Prebid.js

HuddledMasses · 2017-11-07T16:01:14Z

Type of change

New bidder adapter

Description of change

Add adapter and tests for the HuddledMasses header bidding adapter

test parameters for validating bids

{
   bidder: 'huddledmasses',
   params: {
      placement_id: 0
    }
}

contact email of the adapter’s maintainer: supply@huddledmasses.com
official adapter submission

mkendall07 · 2017-11-10T12:42:01Z

@HuddledMasses
Why did you rename the previous adapter and now submitting a new one? This is confusing.

HuddledMasses · 2017-11-10T14:03:06Z

@mkendall07
sorry fo confusion. at last minute we made a decision to keep two adapters; so we will have one for Colossus, another for Huddled Masses

mkendall07 · 2017-11-10T15:50:25Z

@HuddledMasses
And the code for the adapters is discrete (and the endpoints?)

HuddledMasses · 2017-11-10T16:05:11Z

@mkendall07
yes, both the code and the endpoints are discrete.

HuddledMasses · 2017-11-13T13:56:28Z

Hi @mkendall07 Any update on this? will appreciate. Thanks!

mkendall07 · 2017-11-13T22:14:11Z

modules/huddledmassesBidAdapter.js

+   */
+  isBidRequestValid: (bid) => {
+    return (!isNaN(bid.params.placement_id) &&
+    ((bid.params.sizes != undefined && bid.params.sizes.length > 0 && bid.params.sizes.some((sizeIndex) => INDEX_SIZE[sizeIndex] != undefined)) ||


we prefer triple equality (!==).

mkendall07 · 2017-11-13T22:15:24Z

modules/huddledmassesBidAdapter.js

+  '800x250': 118,
+  '200x600': 119
+};
+const INDEX_SIZE = {


You don't need to duplicate this data. You can do a reverse lookup by iterating the object properties.

mkendall07 · 2017-11-13T22:17:57Z

modules/huddledmassesBidAdapter.js

+    } catch (e) {
+      console.log(e);
+    };
+    let location = winTop.location;


You can use utils.getTopWindowLocation() instead of the code above: https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L157

mkendall07 · 2017-11-13T22:19:40Z

modules/huddledmassesBidAdapter.js

+        }
+      }
+    } catch (e) {
+      console.log(e);


please use utils.logMessage() instead

mkendall07 · 2017-11-13T22:20:01Z

modules/huddledmassesBidAdapter.md

+```
+Module Name: HuddledMasses Bidder Adapter
+Module Type: Bidder Adapter
+Maintainer: prebid@example.com


Please update email

mkendall07 · 2017-11-13T22:40:52Z

modules/huddledmassesBidAdapter.js

+  interpretResponse: (serverResponse) => {
+    let response = [];
+    try {
+      serverResponse = serverResponse.body;


this line needs to be serverResponse.body.body;. Otherwise no bids are returned.

Here I do not agree.
Example response:

{ "body": [{ "width": 300, "height": 250, "ad": "<img src='http://supply.huddledmasses.com/img/logo.png' style='position: absolute; left: 50%; top:50%; margin-left: -113px; margin-top:-79px;'>", "requestId": "26042378f97b21", "cpm": 5, "ttl": 120, "creativeId": "123", "netRevenue": true, "currency": "USD", "dealId": "HASH" }] }

it's broke. Run the code

I cant understand whats wrong.
Why doesn't it work for you.
Here is the test page with the given adapter:
http://hb-test.huddledmassessupply.com/
I do not understand why it does not work for you.

@HuddledMasses
The API changed. Please rebase to master.

On your test page replace http://hb-test.huddledmassessupply.com/prebid-core.js with the latest code and you will see the issue.

Here is the code changed: https://github.com/prebid/Prebid.js/blob/master/src/adapters/bidderFactory.js#L285

I replaced the response at the server level.
Now it should work

[{ "width": 300, "height": 250, "ad": "<img src='http://supply.huddledmasses.com/img/logo.png' style='position: absolute; left: 50%; top:50%; margin-left: -113px; margin-top:-79px;'>", "requestId": "26042378f97b21", "cpm": 5, "ttl": 120, "creativeId": "123", "netRevenue": true, "currency": "USD", "dealId": "HASH" }]

HuddledMasses · 2017-11-14T21:03:15Z

All rights are included.
Only the function interpretResponse remained the same.
The comment with an example of a response from the server is left above.

* unstream/master: (36 commits) + Add Optimatic Bid Adapter (prebid#1837) Add Bridgewell adapter (prebid#1825) Kumma adapter updated for Prebid 1.0 (prebid#1766) Touchup add bid response (prebid#1822) Fix skipped test (prebid#1836) Added new size in Rubicon pbjs Adapter (prebid#1842) HuddledMasses header bidding adapter (prebid#1806) Increment pre version Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) ...

Bill Newman and others added 6 commits October 23, 2017 23:11

create adapter huddledmasses

2860f73

Trigger for current build rerun on Travis CI

5094b60

Migrating to 1.0 spec

20dd679

remove unused variables

c2bbb35

bringing the code to the standard

a77b7dc

Correction of the response validation test

5bb4caf

HuddledMasses mentioned this pull request Nov 8, 2017

New Adapter - Huddled Masses for approval #1808

Closed

matthewlane requested a review from mkendall07 November 8, 2017 16:08

matthewlane assigned mkendall07 Nov 8, 2017

matthewlane added the needs review label Nov 8, 2017

Merge branch 'master' into master

1556cc2

mkendall07 suggested changes Nov 13, 2017

View reviewed changes

mkendall07 added needs update not receiving bids and removed needs review labels Nov 13, 2017

Vlad added 2 commits November 14, 2017 22:55

Adaptation of the adapter

1dc5c1a

Merge branch 'master' of https://github.com/HuddledMasses/Prebid.js

d5dbe94

mkendall07 merged commit d3905fe into prebid:master Nov 14, 2017

HuddledMasses mentioned this pull request Dec 1, 2017

Huddled Masses Adapter is not downloading #1907

Closed

Conversation

HuddledMasses commented Nov 7, 2017

Type of change

Description of change

Uh oh!

mkendall07 commented Nov 10, 2017

Uh oh!

HuddledMasses commented Nov 10, 2017

Uh oh!

mkendall07 commented Nov 10, 2017

Uh oh!

HuddledMasses commented Nov 10, 2017

Uh oh!

HuddledMasses commented Nov 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HuddledMasses Nov 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HuddledMasses commented Nov 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

HuddledMasses Nov 14, 2017 •

edited

Loading