AOL adapter - dropping pixels when creatives in safe frames.#2816
AOL adapter - dropping pixels when creatives in safe frames.#2816vzhukovsky wants to merge 1 commit intoprebid:masterfrom
Conversation
| expect(formattedPixels).to.equal( | ||
| '<script>var w=window,prebid;' + | ||
| 'for(var i=0;i<10;i++){w = w.parent;prebid=w.$$PREBID_GLOBAL$$;' + | ||
| 'try{for(var i=0;i<10;i++){w = w.parent;prebid=w.$$PREBID_GLOBAL$$;' + |
There was a problem hiding this comment.
1.0 compliant adapters are not permitted to reference
There was a problem hiding this comment.
@mike-chowla
Hi. Thank you for reviewing.
It has been there since we updated our adapter for 1.0. In migration PR we provided more details about this feature (#1693) and it was accepted.
Actually, we don't drop own pixels. It is exactly the same pixels that are dropped via getUserSyncs but attached to the ad content. This feature allows to avoid making extra user syncs request and as a result, reduce the load on the server.
We would be happy if there was something similar in Prebid official.
There was a problem hiding this comment.
I actually rejected the initial pull-request partially because of the custom pixels and it doesn't look like it was resolved before being merged. I still feel the same way I did then but I'm fine with being overruled; I'll assign @mkendall07 to review and see with how he feels (if this needs to be fixed now or not).
mkendall07
left a comment
mkendall07
left a comment
There was a problem hiding this comment.
I'd reject this because no adapter should be touching the $$PREBID_GLOBAL$$ variable. The pixel dropping inside the creative is allowed since we haven't explicitly restricted it.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@mkendall07 I'd say let's keep as is with using globals here until the container explicitly restricts dropping pixels inside the creatives. |
|
You still need to remove references to |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
4 participants
Type of change
Description of change
Fixed dropping pixels when creatives are served into safe frames.