Update adapter to prebid v1.0 by Spacedragoon · Pull Request #1908 · prebid/Prebid.js

Spacedragoon · 2017-12-01T10:20:21Z

Type of change

Description of change

Version 1.0 of the Smart Bidder Adapter, every mandatory params and optional params are the same as previous version

test parameters for validating bids

{
  sizes: [[320, 250]],
  bids: [{
    bidder: "smartadserver",
    params: {
      siteId: 32216,
      pageId: 881291,
      formatId: 13695,
      domain: 'http://prg.smartadserver.com'
    }
  }]
}

Be sure to test the integration with your adserver using the Hello World sample page.

gcarnec@smartadserver.com
official adapter submission

Other information

snapwich · 2017-12-05T19:43:15Z

modules/smartadserverBidAdapter.js

-        adloader.loadScript(url.format(adCall));
-      }
+    // pull requested transaction ID from bidderRequest.bids[].transactionId
+    if (!Array.isArray(validBidRequests)) {


This will always be an array, so this is unnecessary

snapwich · 2017-12-05T19:44:46Z

modules/smartadserverBidAdapter.js

+      siteid: bid.params.siteId,
+      pageid: bid.params.pageId,
+      formatid: bid.params.formatId,
+      currencyCode: config.getConfig('currency'),


'currency' is an object, do you mean 'currency.adServerCurrency'?

snapwich · 2017-12-05T19:47:27Z

modules/smartadserverBidAdapter.js

+   */
+  interpretResponse: function (serverResponse, bidRequest) {
+    const bidResponses = [];
+    if (serverResponse) {


serverResponse is now split into two properties. serverResponse.body and serverResponse.headers. I think you're wanting to get all the stuff off serverResponse.body here.

snapwich · 2017-12-05T19:48:36Z

modules/smartadserverBidAdapter.js

+  },
+  getUserSyncs: function (syncOptions) {
+    // iframe || image
+    return undefined;


If you're not using userSyncs, just don't include this function definition rather than returning undefined.

snapwich · 2017-12-08T17:08:51Z

modules/smartadserverBidAdapter.js

      pageid: bid.params.pageId,
      formatid: bid.params.formatId,
-      currencyCode: config.getConfig('currency'),
+      currencyCode: config.getConfig('currency').adServerCurrency,


You should use config.getConfig('currency.adServerCurency') since the config module does safe deep access. The way you have it here if currency hasn't been set then it will throw "can't read adServerCurrency of undefined" error.

Spacedragoon · 2017-12-19T15:00:21Z

Hello,
Any news about my last changes ?

snapwich · 2017-12-19T19:29:26Z

@Spacedragoon you have conflicts that need to be resolved

Spacedragoon · 2017-12-20T10:14:50Z

Hello,
conflicts resolved.

snapwich

LGTM

matthewlane

Are the test parameters in smartadserverBidAdapter.md still valid? Currently getting a 200 OK but empty response when using those for testing. Also one change requested below

matthewlane · 2018-01-03T18:06:39Z

modules/smartadserverBidAdapter.js

+    if (response) {
+      const bidResponse = {
+        requestId: bidRequest.bidId,
+        bidderCode: spec.code,


bidderCode will be set automatically by bidderFactory now, this line can be dropped

matthewlane · 2018-01-04T17:59:39Z

@Spacedragoon Updates look, but still getting an empty response with the updated test parameters.

The way I'm testing is taking those params and putting them in the hello_world test page bids array, running gulp serve from the Prebid directory, and opening the test page in a browser. In the dev console, running pbjs.getBidResponses() returns an empty object, and in the network tab, the request to http://prg.smartadserver.com is 200 OK but the response is empty. Are you getting different results in this setup?

Once bid responses are verified this should be good for merge.

Spacedragoon · 2018-01-05T11:03:20Z

Alright, it didn't work because i assumed the code here would work just by filling the blanks.

But the line requestId: bidRequest.bidId, in interpretResponse function puts undefined as a value in requestId if you follow the lines of the buildRequests function just above :
return { method: 'POST', url: ENDPOINT_URL, data: payloadString, };

It may be a good idea to review this part of the documentation

snapwich · 2018-01-08T19:14:23Z

Unfortunately the location the requestId comes from can't just be fill in the blank, because in reality in depends on your request architecture. For most, attaching the request containing the bidId to the server request and getting back in the response handler like shown is fine, but for people who have implemented some kind of single request architecture, they'll need to map their response back to the appropriate IDs.

The documentation doesn't describe that process very well, I'll see if I can update it to clarify what that id is and how to get it.

matthewlane · 2018-01-17T17:37:57Z

@Spacedragoon still getting no response data with the test parameters and updated code, with the setup described here, checking on this again so we can validate bid responses and get this merged

Spacedragoon · 2018-01-22T15:01:24Z

Hello @matthewlane I tested it again here and it seems to work : you can see the response from our side, plus the bidResponses in pbjs.

matthewlane

@Spacedragoon Ok, thanks. One more required change then will merge

matthewlane · 2018-01-22T17:12:13Z

modules/smartadserverBidAdapter.js

+    var response = serverResponse.body;
+    if (response) {
+      const bidResponse = {
+        requestId: JSON.parse(bidRequest.data).bidId,


Any JSON.parse calls should be wrapped in a try/catch block

Spacedragoon · 2018-01-23T09:54:59Z

@matthewlane Alright, done.

matthewlane · 2018-01-23T16:36:45Z

Thanks, this is merged. Please also submit a PR to update your bidder file in the docs repo, to add the line prebid_1_0_supported: true to the header, and make any updates to the bidder params if necessary

Spacedragoon · 2018-01-24T09:56:19Z

@matthewlane Thank you, the PR for the docs repo is now done here

* 'master' of https://github.com/prebid/Prebid.js: Prebid 1.2.0 Release Use polyfilled includes method (prebid#2061) RockYou Adapter: Added RockYou Adapter supporting Prebid 1.0 (prebid#1977) Optimera Adapter for 1.0. (prebid#1961) Use cross-browser integer check (prebid#2058) Fix skipped test (prebid#2059) Support multiple media formats within a single ad unit (prebid#1991) pre1api module that allows use of deprecated pre1.0 API in Prebid 1.0 (prebid#1976) Colossus SSP header bidding adapter 1.0.0 (prebid#2029) InSkin Bidder Adapter (prebid#2016) Update adapter to prebid v1.0 (prebid#1908) PubMatic 1.0 adapter (prebid#2011)

Update adapter to prebid v1.0

a6762af

matthewlane added the needs review label Dec 1, 2017

matthewlane assigned ndhimehta Dec 2, 2017

snapwich requested changes Dec 5, 2017

View reviewed changes

ndhimehta assigned snapwich Dec 5, 2017

corrected some things following pullrequest review

2e86861

snapwich reviewed Dec 8, 2017

View reviewed changes

slight change to avoid potential error

35b3ec6

Spacedragoon added 2 commits December 20, 2017 10:58

added the maintainer email

aea62dc

merged master to resolve conflict

33aad90

Updated the tests to fit changes

fea1e24

snapwich approved these changes Dec 20, 2017

View reviewed changes

snapwich added LGTM and removed needs review labels Dec 20, 2017

matthewlane reviewed Jan 3, 2018

View reviewed changes

matthewlane added the needs update label Jan 3, 2018

matthewlane assigned matthewlane and unassigned snapwich and ndhimehta Jan 3, 2018

Updated the doc, removed the bidderCode, added adUrl

55056e7

matthewlane added not receiving bids and removed needs update labels Jan 4, 2018

fix adapter

cd90cc8

snapwich mentioned this pull request Jan 8, 2018

clarified interpretResponse requestId prebid/prebid.github.io#533

Merged

matthewlane reviewed Jan 22, 2018

View reviewed changes

Added try catch around JSON.parse

9e3a814

matthewlane approved these changes Jan 23, 2018

View reviewed changes

matthewlane merged commit 9b56b11 into prebid:master Jan 23, 2018

mike-chowla mentioned this pull request Feb 22, 2018

Smart Ad Server: Fix bug when multi bids #2170

Merged

9 tasks

Conversation

Spacedragoon commented Dec 1, 2017

Type of change

Description of change

Other information

Uh oh!

snapwich Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

snapwich Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

snapwich Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

snapwich Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

snapwich Dec 8, 2017

Choose a reason for hiding this comment

Uh oh!

Spacedragoon commented Dec 19, 2017

Uh oh!

snapwich commented Dec 19, 2017

Uh oh!

Spacedragoon commented Dec 20, 2017

Uh oh!

snapwich left a comment

Choose a reason for hiding this comment

Uh oh!

matthewlane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthewlane Jan 3, 2018

Choose a reason for hiding this comment

Uh oh!

matthewlane commented Jan 4, 2018

Uh oh!

Spacedragoon commented Jan 5, 2018

Uh oh!

snapwich commented Jan 8, 2018

Uh oh!

matthewlane commented Jan 17, 2018

Uh oh!

Spacedragoon commented Jan 22, 2018

Uh oh!

matthewlane left a comment

Choose a reason for hiding this comment

Uh oh!

matthewlane Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

Spacedragoon commented Jan 23, 2018

Uh oh!

matthewlane commented Jan 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Spacedragoon commented Jan 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

matthewlane left a comment •

edited

Loading

matthewlane commented Jan 23, 2018 •

edited

Loading