Smart Ad Server: Fix bug when multi bids#2170
Merged
mike-chowla merged 1 commit intoprebid:masterfrom Mar 23, 2018
Merged
Conversation
mike-chowla
changed the title
Contributor
|
I tried testing this with the parameters from #1908 but I'm not getting any bids back Here's the request body: |
Contributor
Author
|
Hey @mike-chowla, Indeed the parameters in this PR are out dated, and were actually changed in the md file. the right ones are They just weren't updated in the PR message at the time. Sorry about that. |
Contributor
|
I tried with the new params and am still not getting any bids back. Response is 200 status code, content length 0 Request body: |
Contributor
Author
|
Hey @mike-chowla, I don't get it, I tried with your exact request body (copy/paste) with a rest client and i get the response. I also tried with the test page locally and it works just fine. |
Contributor
Author
|
Hello @mike-chowla, As I said it works when i try, could you try again ? Also, If it still doesn't work could you show the Url you are calling ? |
Contributor
|
Sorry for the slow response. I'd been in India and I thought that might have something to do with the issue. I tried again and I'm still not getting any bids.
|
Contributor
Author
|
Hello @mike-chowla I know it's a bit annoying but i don't understand why you don't have any responses. |
Contributor
|
Hi @mike-chowla, Thank you. |
Contributor
|
With those new parameters, I do get bids back but the ad is not rendering properly
|
Contributor
|
Could you please provide a HAR file so we could compare with our test? Do you have any errors in the console? In any case for us it is a valid JSON as a response, the test doesn't return any creative to show. Thank you. |
Contributor
|
The test parameters need to return a valid ad. HAR File: There's actually 2 issues. The 0.05 cpm you are sending back is getting put in the zero price bucket which causes ads not to display with hello_world.html. I can hack around that but you should really send a test ad back with a higher cpm to stay out of that bucket. The adapter code returns ad field as the creative and as that field is coming back as JSON, it's not a valid creative Here's what I'm getting back. |
Contributor
|
Hi @mike-chowla , Could you please test again? Thank you. |
mike-chowla
approved these changes
Mar 23, 2018
Contributor
mike-chowla
left a comment
mike-chowla
left a comment
There was a problem hiding this comment.
LTGM. Test ad works . 2 slots works. Would be a good idea to add a test for the multiple ad slot case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Support multi bids
Other information
See issue #2166