Merged
Conversation
matthewlane
reviewed
Jan 29, 2018
modules/iasBidAdapter.js
Outdated
| // Necessary to get around with prebid's common bid response check | ||
| const commonBidResponse = { | ||
| requestId: request.bidRequest.bidId, | ||
| cpm: 1, |
Collaborator
There was a problem hiding this comment.
Can this be changed to 0.01? The hardcoded 1 may prevent bidders with real cpms from winning
Contributor
Author
|
Hi @matthewlane , |
matthewlane
approved these changes
Jan 31, 2018
Collaborator
|
@katzhang-ias Please also submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page |
Contributor
Author
|
Thanks @matthewlane ! Will do. |
Contributor
Author
|
Docs PR: prebid/prebid.github.io#595 |
Contributor
Author
|
Please let me know if there's anything else that needs to be done to get it merged/released. |
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Feb 12, 2018
* 'master' of https://github.com/prebid/Prebid.js: (51 commits) Update maintainer email (prebid#2132) Replace event string with constant (prebid#2128) Add adapter for IAS (prebid#2056) Fix sovrn dealid (prebid#2119) Added support for NURL and ADM as backup (prebid#2112) fix bug where hooked functions w/ no hooks weren't ran immediately (prebid#2115) Increment pre version Prebid 1.3.1 Release Omit app and device if not present rather than send false (prebid#2116) Increment pre version Prebid.js 1.3.0 Release Unit test fixes (prebid#2111) must explicitly list pre1api for it to be included in build (prebid#2097) adkernel adapter additional bid parameters (prebid#2105) removing userSync (prebid#2032) 33across Bid Adapter: Bugfix + Refactor (prebid#2024) Port calling order fix to 1.x (prebid#2067) Update adform adapter request (prebid#2107) Serverbid Bid Adapter: getUserSyncs and new adsizes (prebid#2106) Add hfa and pv parameter to request payload (prebid#2109) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This module is an integration with prebid.js with an IAS product, pet.js. It is not a bidder per se but works in a similar way: retrieve data that publishers might be interested in setting keyword targeting.
Be sure to test the integration with your adserver using the Hello World sample page.